Skip to content

Disabled oneDNN reshape1/2 and squeeze1/2 kernels #35781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 17, 2021
Merged

Disabled oneDNN reshape1/2 and squeeze1/2 kernels #35781

merged 3 commits into from
Sep 17, 2021

Conversation

jakpiase
Copy link
Contributor

@jakpiase jakpiase commented Sep 15, 2021 •
edited
Loading

PR types

Bug fixes

PR changes

OPs

Describe

This PR disables reshape and squeeze kernels. It must be done, because I am not able to easily fix bugs with these ops.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@jakpiase jakpiase added the Intel label Sep 15, 2021
@baoachun
Copy link
Contributor

@jakpiase
Hi，thank you for your contribution！The problem 1、2、3、5 have been solved for the lastest develop branch but not this pr, I think maybe you should test whether the problem 4 and the pcpvt_base model prediction result diff bug have been solved for this pr.
图片

@jakpiase
Copy link
Contributor Author

@baoachun do you know which PR has solved 1,2,3,5 issues?

@baoachun
Copy link
Contributor

@jakpiase
I think maybe this #35706, but not sure.

@jakpiase jakpiase changed the title Disabled oneDNN matmul_v2 grad Disabled oneDNN reshape1/2 and squeeze1/2 kernels Sep 16, 2021
This was referenced Sep 16, 2021
Closed
Closed
@baoachun
Copy link
Contributor

@jakpiase
Hi， are there any progress？

wozna
wozna approved these changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@wozna wozna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakpiase jakpiase requested review from jczaja and wozna September 17, 2021 09:46
JiaXiao243
JiaXiao243 approved these changes Sep 17, 2021
View reviewed changes
Copy link

@JiaXiao243 JiaXiao243 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
df89842123643ff03bcda6e4f7a1b276
186b4e3143b768bc6ef57a1064fdc09f
5d918b681374fc375d37041adef354b3

@jczaja jczaja merged commit 0eaab80 into PaddlePaddle:develop Sep 17, 2021
@jakpiase jakpiase mentioned this pull request Sep 17, 2021
Closed
AnnaTrainingG pushed a commit to AnnaTrainingG/Paddle that referenced this pull request Sep 29, 2021
@jakpiase @AnnaTrainingG
Disabled oneDNN reshape1/2 and squeeze1/2 kernels (PaddlePaddle#35781)
ec04916 
* disabled matmul_v2 grad

* Revert "disabled matmul_v2 grad"

This reverts commit b569bce.

* reverted disabling matmul_v2, disabled reshape and squeeze
@YuanRisheng YuanRisheng mentioned this pull request Sep 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiaXiao243 JiaXiao243 JiaXiao243 approved these changes

@jczaja jczaja Awaiting requested review from jczaja

@wozna wozna Awaiting requested review from wozna

Assignees
No one assigned
Labels
Intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jakpiase @baoachun @wozna @JiaXiao243 @jczaja