Skip to content

[Infra] Auto install pybind11-stubgen in cmake stage #71911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented Mar 26, 2025

PR Category

Environment Adaptation

PR Types

Devs

Description

cmake 阶段自动安装 pybind11-stubgen

Copy link

paddle-bot bot commented Mar 26, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Comment on lines 69 to 74
if(_pybind11_stubgen_status EQUAL 0)
return()
endif()

execute_process(COMMAND ${PYTHON_EXECUTABLE} -m pip install -U
pybind11-stubgen)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if(_pybind11_stubgen_status EQUAL 0)
return()
endif()
execute_process(COMMAND ${PYTHON_EXECUTABLE} -m pip install -U
pybind11-stubgen)
if(NOT _pybind11_stubgen_status EQUAL 0)
execute_process(COMMAND ${PYTHON_EXECUTABLE} -m pip install -U
pybind11-stubgen)
endif()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不要,我就要 early return

gouzil
gouzil previously approved these changes Mar 26, 2025
risemeup1
risemeup1 previously approved these changes Mar 26, 2025
@SigureMo SigureMo dismissed stale reviews from risemeup1 and gouzil via 8dd4637 March 26, 2025 06:20
@SigureMo SigureMo merged commit ca53e2b into PaddlePaddle:develop Mar 26, 2025
32 checks passed
@SigureMo SigureMo deleted the infra/auto-install-pybind11-stubgen-in-cmake branch March 26, 2025 15:15
co63oc pushed a commit to co63oc/Paddle that referenced this pull request Mar 27, 2025
YqGe585 pushed a commit to YqGe585/Paddle that referenced this pull request May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants