Skip to content

[Infra] Auto install pybind11-stubgen in cmake stage #71911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 26, 2025
Merged

[Infra] Auto install pybind11-stubgen in cmake stage #71911

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d35e913
[Infra] Auto install `pybind11-stubgen` in cmake stage
SigureMo Mar 26, 2025
5ec6ef8
remove version check
SigureMo Mar 26, 2025
3363194
move to pybind dir
SigureMo Mar 26, 2025
8dd4637
remove `pybind11-stubgen` from `requirements.txt`
SigureMo Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions paddle/fluid/operators/generator/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,26 @@ function(install_py_jinja2)
execute_process(COMMAND ${PYTHON_EXECUTABLE} -m pip install -U jinja2)
endfunction()

function(install_py_pybind11_stubgen)
# check install
execute_process(
COMMAND
${PYTHON_EXECUTABLE} "-c"
"import re, pybind11_stubgen; print(re.compile('/__init__.py.*').sub('',pybind11_stubgen.__file__))"
RESULT_VARIABLE _pybind11_stubgen_status
ERROR_QUIET OUTPUT_STRIP_TRAILING_WHITESPACE)

if(_pybind11_stubgen_status EQUAL 0)
return()
endif()

execute_process(COMMAND ${PYTHON_EXECUTABLE} -m pip install -U
pybind11-stubgen)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if(_pybind11_stubgen_status EQUAL 0)
return()
endif()
execute_process(COMMAND ${PYTHON_EXECUTABLE} -m pip install -U
pybind11-stubgen)
if(NOT _pybind11_stubgen_status EQUAL 0)
execute_process(COMMAND ${PYTHON_EXECUTABLE} -m pip install -U
pybind11-stubgen)
endif()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不要，我就要 early return

endfunction()

install_py_pyyaml()
install_py_jinja2()
install_py_pybind11_stubgen()

# parse ops
set(parsed_op_dir ${CMAKE_BINARY_DIR}/paddle/phi/ops/yaml)
Expand Down
Loading