[Kernel] Fix GroupNormGradKernel when d_x is nullptr
#72358
Merged
+103
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
HydrogenSulfate
force-pushed
the
fix_group_norm_cpu
branch
from
655579d to
ecdc6e6
Compare
HydrogenSulfate
force-pushed
the
fix_group_norm_cpu
branch
from
ecdc6e6 to
62e774d
Compare
HydrogenSulfate
requested review from
SigureMo,
zrr1999 and
gouzil
as code owners
zyfncg
approved these changes
Apr 25, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #72358 +/- ##
===========================================
Coverage ? 100.00%
===========================================
Files ? 1
Lines ? 40
Branches ? 0
===========================================
Hits ? 40
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
…e#72358) * fix GroupNormGradKernel when d_x is nullptr * update UT * fix relative import * fix coverage * fix rtol and atol * fix for coverage * update UT * add nhwc for coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Operator Mechanism
PR Types
Bug fixes
Description
Pcard-75624
当x.stop_gradient=True时，d_x为空，CPU的GroupNormGradKernel没有处理这种情况导致报错，因此将逻辑对齐 CUDA GroupNormGradKernel，当
d_x为空时去掉对应的内存申请和相关计算逻辑