refactor(dx8): Replace unsafe Matrix4/D3DMATRIX casts with explicit conversions #1852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobtista
force-pushed
the
bobtista/fix-matrix4-d3d-transpose
branch
from
518ebd4 to
fa2fff2
Compare
xezon
reviewed
Nov 13, 2025
| curView[0][0], curView[0][1], curView[0][2], curView[0][3], | ||
| curView[1][0], curView[1][1], curView[1][2], curView[1][3], | ||
| curView[2][0], curView[2][1], curView[2][2], curView[2][3], | ||
| curView[3][0], curView[3][1], curView[3][2], curView[3][3] |
There was a problem hiding this comment.
This is not good. Too complicated user code repeated again. Please see reference code in the linked report.
Author
There was a problem hiding this comment.
Ok I made a helper instead of using BUILD_WITH_D3D8. This way we can later use Vulkan or something without touching Matrix4x4. I can do it either way, whichever you prefer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces all C-style casts between
Matrix4x4/Matrix3DandD3DXMATRIX/D3DMATRIXwith explicit conversions.