Skip to content

fix(debug): Add error handling for rename failures in Debug code #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 16, 2025
Merged

fix(debug): Add error handling for rename failures in Debug code #1855

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
35befd8
tweak(debug): Add error handling for rename failures in Debug.cpp
Skyaero42 Nov 14, 2025
dd7b58d
chore: Use DebugLog instead of Debug_assert and change log message
Skyaero42 Nov 14, 2025
278009f
Updating
Skyaero42 Nov 15, 2025
9b670f6
sorry I'm a dummy
Skyaero42 Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 37 additions & 3 deletions Core/GameEngine/Source/Common/System/Debug.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,19 @@ void DebugInit(int flags)
strlcat(theLogFileName, ".txt", ARRAY_SIZE(theLogFileNamePrev));

remove(theLogFileNamePrev);
rename(theLogFileName, theLogFileNamePrev);
if (rename(theLogFileName, theLogFileNamePrev) != 0)
{
#ifdef DEBUG_LOGGING
DebugLog("Warning: Could not rename buffer file '%s' to '%s'. Will remove instead", theLogFileName, theLogFileNamePrev);
#endif
if (remove(theLogFileName) != 0)
{
#ifdef DEBUG_LOGGING
DebugLog("Warning: Failed to remove file '%s'", theLogFileName);
#endif
}
}

theLogFile = fopen(theLogFileName, "w");
if (theLogFile != NULL)
{
Expand Down Expand Up @@ -738,7 +750,18 @@ void ReleaseCrash(const char *reason)
strlcat(curbuf, RELEASECRASH_FILE_NAME, ARRAY_SIZE(curbuf));

remove(prevbuf);
rename(curbuf, prevbuf);
if (rename(curbuf, prevbuf) != 0)
{
#ifdef DEBUG_LOGGING
DebugLog("Warning: Could not rename buffer file '%s' to '%s'. Will remove instead", curbuf, prevbuf);
#endif
if (remove(curbuf) != 0)
{
#ifdef DEBUG_LOGGING
DebugLog("Warning: Failed to remove file '%s'", curbuf);
#endif
}
}

theReleaseCrashLogFile = fopen(curbuf, "w");
if (theReleaseCrashLogFile)
Expand Down Expand Up @@ -827,7 +850,18 @@ void ReleaseCrashLocalized(const AsciiString& p, const AsciiString& m)
strlcat(curbuf, RELEASECRASH_FILE_NAME, ARRAY_SIZE(curbuf));

remove(prevbuf);
rename(curbuf, prevbuf);
if (rename(curbuf, prevbuf) != 0)
{
#ifdef DEBUG_LOGGING
DebugLog("Warning: Could not rename buffer file '%s' to '%s'. Will remove instead", curbuf, prevbuf);
#endif
if (remove(curbuf) != 0)
{
#ifdef DEBUG_LOGGING
DebugLog("Warning: Failed to remove file '%s'", curbuf);
#endif
}
}

theReleaseCrashLogFile = fopen(curbuf, "w");
if (theReleaseCrashLogFile)
Expand Down
Loading