Multiplication of interior intervals in the rational numbers #1561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Fredrik Bakke <fredrbak@gmail.com>
src/elementary-number-theory/interior-closed-intervals-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
src/elementary-number-theory/minima-and-maxima-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
src/elementary-number-theory/negation-closed-intervals-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
src/elementary-number-theory/closed-intervals-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
src/elementary-number-theory/closed-intervals-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
fredrik-bakke
approved these changes
Oct 4, 2025
Co-authored-by: Fredrik Bakke <fredrbak@gmail.com>
src/elementary-number-theory/closed-interval-preserving-maps-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
src/elementary-number-theory/closed-interval-preserving-maps-rational-numbers.lagda.md
Show resolved
Hide resolved
src/elementary-number-theory/closed-intervals-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
src/elementary-number-theory/proper-closed-intervals-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Fredrik Bakke <fredrbak@gmail.com>
| ( decide-is-positive-is-nonpositive-ℚ d) | ||
| ``` | ||
|
|
||
| ### Multiplication of interior intervals |
There was a problem hiding this comment.
The stuff on multiplication of interior intervals looks to me should go in a new file too
|
sorry for the slightly patchy review work on this one, but the key takeaway is to remember our one-concept-per-file policy. For instance, when your definitions section has more than 2-3 sections or the file is around 1000 LOC or more, that should suggest that it might be time to break it down into multiple files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe there's a cleaner way, but I don't see it.
This will substantially simplify proving the basic properties of multiplication on the real numbers.