[AIE2] NFC : Refactor Address Space Code #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishnamtibrewala
requested review from
abhinay-anubola,
abnikant,
andcarminati,
gbossu,
khallouh,
konstantinschwarz,
martien-de-jong,
SagarMaheshwari99 and
stephenneuendorffer
as code owners
krishnamtibrewala
force-pushed
the
aie-AS-refactor
branch
from
357f943 to
2190de2
Compare
|
This refactoring looks nice! |
krishnamtibrewala
force-pushed
the
aie-AS-refactor
branch
from
2190de2 to
492fd60
Compare
|
Can you add a rationale in the PR description as to why this change is needed? |
gbossu
reviewed
Oct 1, 2024
krishnamtibrewala
force-pushed
the
aie-AS-refactor
branch
from
492fd60 to
2a2b54e
Compare
gbossu
reviewed
Oct 2, 2024
gbossu
reviewed
Oct 2, 2024
krishnamtibrewala
force-pushed
the
aie-AS-refactor
branch
from
2a2b54e to
6d28fa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR would allow to use a single architecture agnostic AA pass which can do AA using addresspace info.
Kindly refer #173 to see the use case.
Note : AA using addresspace info is guarded by a CMD line option.