[AIE2] Alias Analysis using AddrSpace Info #484
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martien-de-jong
requested review from
abhinay-anubola,
abnikant,
andcarminati,
F-Stuckmann,
gbossu,
katerynamuts,
khallouh,
konstantinschwarz,
niwinanto,
SagarMaheshwari99 and
stephenneuendorffer
as code owners
|
Thank you @martien-de-jong for porting the PR. |
|
Can we extent to aie2p? I see that it covers tile memory for aie2. Maybe it is not important... |
F-Stuckmann
reviewed
Jun 16, 2025
| @@ -82,7 +86,12 @@ class AIEBaseAAWrapperPass : public ImmutablePass { | |||
| const AIEBaseAAResult &getResult() const { return *Result; } | |||
|
|
|||
| bool doInitialization(Module &M) override { | |||
| Result.reset(new AIEBaseAAResult(M.getDataLayout())); | |||
| if (!M.getFunctionList().empty()) { | |||
There was a problem hiding this comment.
If we do not have a function list in the module, shouldn't we still reset previous AliasResults`?
There was a problem hiding this comment.
Theoretically yes. Although no one is going to query it in a module without functions. It seems to need TTI, which is normally found in the function. I wouldn't know where to find it otherwise.
mgehre-amd
added a commit
that referenced
this pull request
Aug 21, 2025
Ensure 0 <= x mod N < N semantics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of Krishnam's original PR #173 which I will close.
I'll be running QoR today-ish.
QoR results are varying. Also, memory bank annotations may not always be respected by the buffer allocation. Although it can be argued that intent of the programmer will usually be to have different objects be designated by pointers to non-overlapping banks, the gain we see doesn't make it worth to take the risk. I converted to draft.