[AIE2] Alias Analysis using AddrSpace Info #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

krishnamtibrewala wants to merge 2 commits into aie-public from aie-AS-alias

Collaborator

krishnamtibrewala commented Aug 28, 2024 •

edited

Loading

The work is guarded under an option --aie-alias-analysis-addrspace.

Note : There are no QoR gain with this work!!

andcarminati reviewed

View reviewed changes

llvm/lib/Target/AIE/AIE2AliasAnalysis.h Outdated Show resolved Hide resolved

andcarminati reviewed

View reviewed changes

llvm/lib/Target/AIE/AIE2AliasAnalysis.cpp Outdated Show resolved Hide resolved

Collaborator

andcarminati commented Sep 2, 2024

Hi @krishnamtibrewala, I think that 05ae54e98b48841d4fb24f0184ff1ab5b630e80f can be moved to another PR.

andcarminati reviewed

View reviewed changes

llvm/lib/Target/AIE/AIE2AddrSpace.h Outdated Show resolved Hide resolved

andcarminati reviewed

View reviewed changes

llvm/lib/Target/AIE/AIE2AddrSpace.h Outdated Show resolved Hide resolved

andcarminati reviewed

View reviewed changes

llvm/lib/Target/AIE/AIE2AddrSpace.h Outdated Show resolved Hide resolved

martien-de-jong reviewed

View reviewed changes

llvm/lib/Target/AIE/AIE2.h Outdated Show resolved Hide resolved

llvm/lib/Target/AIE/AIE2AddrSpace.h Outdated Show resolved Hide resolved

Collaborator

martien-de-jong commented Sep 3, 2024

The work is guarded under an option --aie2-AS-AA.

Does it cause errors in QoR? If so, are they caused by erroneous bank annotations?

Collaborator Author

krishnamtibrewala commented Sep 3, 2024

The work is guarded under an option --aie2-AS-AA.

Does it cause errors in QoR? If so, are they caused by erroneous bank annotations?

Yes, since it can potential error in QoR due to erroneous bank annotations.

krishnamtibrewala mentioned this pull request

[AIEX] NFC : Refactor TargetMachine & PassConfig code #179

Merged

Collaborator Author

krishnamtibrewala commented Sep 3, 2024

Hi @krishnamtibrewala, I think that 05ae54e can be moved to another PR.

have moved the commit to PR #179

krishnamtibrewala force-pushed the aie-AS-alias branch from decda4b to 82380e2 Compare

September 16, 2024 23:41

andcarminati reviewed

View reviewed changes

llvm/lib/Target/AIE/AIE2TargetTransformInfo.cpp Show resolved Hide resolved

Collaborator

andcarminati commented Sep 17, 2024

As a suggestion, we can have PR just for [AIE2] Refactor address space code. In this way we will keep this PR smaller.

krishnamtibrewala mentioned this pull request

[AIE2] NFC : Refactor Address Space Code #188

Merged

krishnamtibrewala force-pushed the aie-AS-alias branch from 82380e2 to 7c9cda7 Compare

October 17, 2024 06:52

krishnamtibrewala marked this pull request as ready for review

October 17, 2024 06:52

krishnamtibrewala requested review from abhinay-anubola, abnikant, gbossu, khallouh, konstantinschwarz, SagarMaheshwari99 and stephenneuendorffer as code owners

October 17, 2024 06:52

krishnamtibrewala requested a review from andcarminati

October 17, 2024 06:52

andcarminati reviewed

View reviewed changes

llvm/lib/Target/AIE/AIE2TargetTransformInfo.cpp Outdated Show resolved Hide resolved

andcarminati reviewed

View reviewed changes

llvm/test/CodeGen/AIE/alias-analysis-AA.ll Outdated Show resolved Hide resolved

krishnamtibrewala force-pushed the aie-AS-alias branch from 7c9cda7 to 71597e9 Compare

October 17, 2024 07:43

andcarminati reviewed

View reviewed changes

llvm/lib/Target/AIE/AIETargetTransformInfo.h Show resolved Hide resolved

krishnamtibrewala force-pushed the aie-AS-alias branch from 71597e9 to 43f5bab Compare

October 17, 2024 08:43

krishnamtibrewala force-pushed the aie-AS-alias branch from 43f5bab to f48189f Compare

October 28, 2024 18:21

krishnamtibrewala added 2 commits

December 3, 2024 10:26


          [AIE2] Annotate AS for load/store to TileMemory

461f749


          [AIE2] Alias Analysis using AddrSpace Info

02d53b8

krishnamtibrewala force-pushed the aie-AS-alias branch from f48189f to 02d53b8 Compare

December 3, 2024 18:38

Collaborator

andcarminati commented Dec 12, 2024

I think this PR can be merged. We should also export some features to be enabled using frontend command line options. Here, something like menable-bank-aa and mno-enable-bank-aa.

martien-de-jong mentioned this pull request

[AIE2] Alias Analysis using AddrSpace Info #484

Draft

Collaborator

martien-de-jong commented Jun 10, 2025

Conflict resolution has been done in a new PR: #484

martien-de-jong closed this

mgehre-amd pushed a commit that referenced this pull request


          Merge pull request #173 from Xilinx/liangta.abs

746aa23

PDLL native operator abs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

andcarminati andcarminati left review comments

martien-de-jong martien-de-jong left review comments

abhinay-anubola Awaiting requested review from abhinay-anubola abhinay-anubola is a code owner

abnikant Awaiting requested review from abnikant abnikant is a code owner

gbossu Awaiting requested review from gbossu

khallouh Awaiting requested review from khallouh khallouh is a code owner

konstantinschwarz Awaiting requested review from konstantinschwarz konstantinschwarz is a code owner

SagarMaheshwari99 Awaiting requested review from SagarMaheshwari99 SagarMaheshwari99 is a code owner

stephenneuendorffer Awaiting requested review from stephenneuendorffer stephenneuendorffer is a code owner

Labels

None yet