Merge show/new page of DataProvider #1553
Conversation
natacha-beck
added
Enhancement
Priority: Normal
Admin
|
It is part of #841 |
| grouped_options.delete(nil) # data providers that can not be on this list return a category name of nil, so we remove them | ||
| grouped_options.keys.sort.map { |type| [ type, grouped_options[type].sort ] } | ||
|
|
||
| return grouped_options || [] |
There was a problem hiding this comment.
Why was this return added? Didn't the previous code return an empty array already?
| return grouped_options || [] | ||
| end | ||
|
|
||
| def get_personal_type_list #:nodoc: |
There was a problem hiding this comment.
What does this method do? Explain please.
There was a problem hiding this comment.
Please add a comment block before the method name
There was a problem hiding this comment.
Why was this file renamed? Since it doesn't include the .erb extension, the tempalate substitutions in it won't work anymore, right?
| grouped_options.keys.sort.map { |type| [ type, grouped_options[type].sort ] } | ||
|
|
||
| return grouped_options || [] | ||
| return grouped_options |
There was a problem hiding this comment.
This is still wrong. It doesn't do what the original code did, which was to return the value computed by the method chain at line 831. Basically, the list you are returning is no longer sorted.
| return grouped_options || [] | ||
| end | ||
|
|
||
| def get_personal_type_list #:nodoc: |
There was a problem hiding this comment.
Please add a comment block before the method name
2 participants
No description provided.