-
Notifications
You must be signed in to change notification settings - Fork 51
Merge show/new page of DataProvider #1553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Changes from 1 commit
d8cf724
cfd7e0e
bb57f44
837f0a5
659e712
4d3bbdc
751ae5c
fb14f49
5a805cc
96dcad4
a5791f8
7fb117b
b69458f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -830,7 +830,7 @@ def get_type_list #:nodoc: | |
grouped_options.delete(nil) # data providers that can not be on this list return a category name of nil, so we remove them | ||
grouped_options.keys.sort.map { |type| [ type, grouped_options[type].sort ] } | ||
|
||
return grouped_options || [] | ||
return grouped_options | ||
end | ||
|
||
def get_personal_type_list #:nodoc: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What does this method do? Explain please. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add a comment block before the method name |
||
|
@@ -849,7 +849,7 @@ def get_personal_type_list #:nodoc: | |
userkey_group << UserkeyFlatDirSshDataProvider.name | ||
grouped_options[category_of_userkey_dp] = userkey_group | ||
|
||
return grouped_options || [] | ||
return grouped_options | ||
end | ||
|
||
|
||
|
|
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still wrong. It doesn't do what the original code did, which was to return the value computed by the method chain at line 831. Basically, the list you are returning is no longer sorted.