Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion BrainPortal/app/assets/stylesheets/cbrain.css.erb
Original file line number Diff line number Diff line change
Expand Up @@ -2586,11 +2586,13 @@ img {

#data_provider_classes {
z-index: 1111;
max-width: 60em;
width: 60%;
position: absolute;
background-color: white;
border: 0.2em solid #0471B4;
padding: 1em;
word-wrap: break-word;
white-space: normal;
}


Expand Down
4 changes: 2 additions & 2 deletions BrainPortal/app/controllers/data_providers_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -830,7 +830,7 @@ def get_type_list #:nodoc:
grouped_options.delete(nil) # data providers that can not be on this list return a category name of nil, so we remove them
grouped_options.keys.sort.map { |type| [ type, grouped_options[type].sort ] }

return grouped_options || []
return grouped_options
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still wrong. It doesn't do what the original code did, which was to return the value computed by the method chain at line 831. Basically, the list you are returning is no longer sorted.

end

def get_personal_type_list #:nodoc:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this method do? Explain please.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment block before the method name

Expand All @@ -849,7 +849,7 @@ def get_personal_type_list #:nodoc:
userkey_group << UserkeyFlatDirSshDataProvider.name
grouped_options[category_of_userkey_dp] = userkey_group

return grouped_options || []
return grouped_options
end


Expand Down
7 changes: 6 additions & 1 deletion BrainPortal/app/views/data_providers/show.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,12 @@
<% t.edit_cell(:type, :content => @provider.type) do |f| %>
<%= f.select :type, grouped_options_for_select(@typelist, @provider.type) %>
<% if !is_normal_user %>
<%= overlay_ajax_link "(Data Provider Type Information)", "/doc/data_providers/data_provider_info.html", :class => "help_link" %>
<div class="field_explanation"><%= show_hide_toggle "(Data Provider Type Information)", "#data_provider_classes", :class => 'action_link' %></div>
</p>

<div id="data_provider_classes" style="display:none">
<%= render :partial => 'dp_types_explained' %>
</div>
<% end %>
<% end %>
<% else %>
Expand Down
129 changes: 0 additions & 129 deletions BrainPortal/public/doc/data_providers/dp_types_explained.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this file renamed? Since it doesn't include the .erb extension, the tempalate substitutions in it won't work anymore, right?

This file was deleted.