Skip to content

Conversation

funnyboy-roks
Copy link
Member

No description provided.

@funnyboy-roks funnyboy-roks added the question Further information is requested label May 12, 2025
@funnyboy-roks funnyboy-roks self-assigned this May 12, 2025
@funnyboy-roks
Copy link
Member Author

Note: this current "solution" does not work because it does not import things like keybinds or themes, only the languages.

@Erik-Claros
Copy link
Contributor

languages.

Couldn't we potentially store what we use locally, key binds and themes, and only have the languages call the library

@funnyboy-roks
Copy link
Member Author

languages.

Couldn't we potentially store what we use locally, key binds and themes, and only have the languages call the library

This issue here is not a matter of local vs external. The issue is that the mechanism that we use to embed all languages, keybinds, etc. into the application (import 'ace-builds/esm-resolver') cases NextJS to take a very long time on the "Collecting Page Data" step.

When you say "store what we use locally", I don't understand what you mean. Part of the compilation step is to get all of these dependencies (languages, keybinds, etc.) and bundle them into our build. The library will then load these from the static files at runtime.

This PR currently replaces that dynamic loading with making the client load all of the languages when the page opens, which seems to work (since we remove the esm-resolver), it is very bad as it makes the client much heavier. It also has the downside that we need to add new languages and such to the array.

We'd also need need to add the same for anything that the editor depends on in order to get full functionality: themes, keybinds, maybe even more that I don't know.

@funnyboy-roks funnyboy-roks linked an issue May 15, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building the application takes 5+ minutes
2 participants