Skip to content

fix failed recognition of custom containerfile due to Windows paths (e.g C:\some\path) being misinterpreted as git urls #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix failed recognition of custom containerfile due to Windows paths (e.g C:\some\path) being misinterpreted as git urls #1286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion podman_compose.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2834,7 +2834,9 @@ def is_context_git_url(path: str) -> bool:
return True
# URL contains a ":" character, a hint of a valid URL
if r.scheme != "" and r.netloc == "" and r.path != "":
return True
# On Windows, this could be a drive letter, so we need to check the scheme
if not (os.name == "nt" and len(r.scheme) == 1):
return True
if r.scheme == "": # tweak path URL to get username from url parser
r = urllib.parse.urlparse("ssh://" + path)
if r.username is not None and r.username != "":
Expand Down