fix failed recognition of custom containerfile due to Windows paths (e.g C:\some\path) being misinterpreted as git urls
#1286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metroite
changed the title
metroite
changed the title
metroite
force-pushed
the
main
branch
2 times, most recently
from
b2e2526 to
3145b02
Compare
metroite
changed the title
C:\some\path) being misinterpreted as git urls
|
@metroite Seems that the PR does not contain any changes. |
…eing misinterpreted as git urls Signed-off-by: Metroite <22453965+Metroite@users.noreply.github.com>
metroite
force-pushed
the
main
branch
2 times, most recently
from
d5be817 to
cdf553f
Compare
Thank you. I don't know how that happened, but thats probably due to the now roughly 50 force pushes for 3 lines of code. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to docker-compose spec.
See minimal example (works with docker compose, not with podman).
This error occurs when trying to run any podman-compose.yml with a build
context:anddockerfile:directive:There is a line in
is_context_git_url()which checks for a:in the context path. As Windows uses:to seperate drives, this results in a bad assertion of every Windows path as a git context.