[WIP]: Adding multiple Spark Master environment variables #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rapoth
changed the title
imback82
reviewed
May 5, 2019
| @@ -22,7 +23,7 @@ internal sealed class ConfigurationService : IConfigurationService | |||
| public const string WorkerReadBufferSizeEnvName = "spark.dotnet.worker.readBufferSize"; | |||
| public const string WorkerWriteBufferSizeEnvName = "spark.dotnet.worker.writeBufferSize"; | |||
|
|
|||
| private const string SparkMasterEnvName = "spark.master"; | |||
| private readonly string[] SparkMasterEnvName = new string[] { "spark.master", "MASTER" }; | |||
There was a problem hiding this comment.
I don't think this is the right fix. I think we should just merge DefaultConfiguration/LocalConfiguration/DebugConfiguration into one, so that the configuration creation is independent of spark master env variable.
|
This will be addressed in #92. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running in Azure Databricks (see below: Create Job -> Select JAR), spark.master is not set but instead MASTER is set to point to the Master URI. This change introduces the check for MASTER in addition to spark.master.
So we can do the best job, please check:
Fixes #nnnnin your description to cause GitHub to automatically close the issue(s) when your PR is merged.