Skip to content

Simplify configuration service. #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2019
Merged

Conversation

imback82
Copy link
Contributor

@imback82 imback82 commented May 6, 2019

This addresses #91 where we remove dependency on spark.master environment variable.

@imback82 imback82 requested review from rapoth and suhsteve May 6, 2019 02:23
@imback82 imback82 self-assigned this May 6, 2019
@imback82 imback82 added the enhancement New feature or request label May 6, 2019
Copy link
Contributor

@rapoth rapoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imback82 imback82 merged commit 95d86e7 into dotnet:master May 7, 2019
@imback82 imback82 deleted the configruation branch May 11, 2019 05:22
@joperezr
Copy link
Member

After this change, the instructions here: https://github.com/dotnet/spark/blob/master/docs/getting-started/windows-instructions.md and here: are no longer valid since they show the wrong environment variable name for the worker process. I will submit a PR soon to fix the docs in this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants