Skip to content

Conversation

DtDamianGrzes
Copy link
Contributor

No description provided.

@DtDamianGrzes DtDamianGrzes requested a review from Copilot July 1, 2025 09:33
Copilot

This comment was marked as outdated.

@DtDamianGrzes DtDamianGrzes force-pushed the feature/separate_build_workflow branch from 851db45 to 10cb222 Compare July 1, 2025 09:39
@DtDamianGrzes DtDamianGrzes requested a review from Copilot July 1, 2025 09:40
Copilot

This comment was marked as duplicate.

@DtDamianGrzes DtDamianGrzes requested a review from Copilot July 1, 2025 10:00
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors CI workflows into a standalone build-package workflow, updates the publish workflow to consume it, and includes minor SDK improvements.

  • Add __hash__ to EndpointStatus for hashability.
  • Simplify singleton creation and fix event-property iteration in extension.py.
  • Extract build, test, and lint steps into a reusable build-package.yml; update publish.yml to use it.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
dynatrace_extension/sdk/status.py Added __hash__ method to EndpointStatus.
dynatrace_extension/sdk/extension.py Simplified super().__new__ call and corrected loop to use value.
dynatrace_extension/sdk/communication.py Annotated inline yaml import with # noqa: PLC0415.
.github/workflows/publish.yml Refactored to call new reusable workflow and removed redundant steps.
.github/workflows/build-package.yml New workflow defining build, test, lint, and packaging steps.
Comments suppressed due to low confidence (1)

.github/workflows/publish.yml:13

  • The ::set-output command is deprecated in GitHub Actions. Switch to the GITHUB_OUTPUT file syntax, e.g.: echo "match=$(...)" >> "$GITHUB_OUTPUT".
        run: echo "::set-output name=match::$(echo '${{ github.ref }}' | grep -Pq '^refs/tags/v\d+\.\d+\.\d+$' && echo true || echo false)"

@DtDamianGrzes DtDamianGrzes changed the title Standalone build workflow to be used by publish workflow and on new PRs Standalone build workflow to be used by publish workflow and on new PRs & linter fixes Jul 1, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
needs: build-package
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DtDamianGrzes DtDamianGrzes merged commit 9bee759 into main Jul 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants