-
Notifications
You must be signed in to change notification settings - Fork 5
Standalone build workflow to be used by publish workflow and on new PRs & linter fixes #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
851db45
to
10cb222
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors CI workflows into a standalone build-package workflow, updates the publish workflow to consume it, and includes minor SDK improvements.
- Add
__hash__
toEndpointStatus
for hashability. - Simplify singleton creation and fix event-property iteration in
extension.py
. - Extract build, test, and lint steps into a reusable
build-package.yml
; updatepublish.yml
to use it.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
dynatrace_extension/sdk/status.py | Added __hash__ method to EndpointStatus . |
dynatrace_extension/sdk/extension.py | Simplified super().__new__ call and corrected loop to use value . |
dynatrace_extension/sdk/communication.py | Annotated inline yaml import with # noqa: PLC0415 . |
.github/workflows/publish.yml | Refactored to call new reusable workflow and removed redundant steps. |
.github/workflows/build-package.yml | New workflow defining build, test, lint, and packaging steps. |
Comments suppressed due to low confidence (1)
.github/workflows/publish.yml:13
- The
::set-output
command is deprecated in GitHub Actions. Switch to theGITHUB_OUTPUT
file syntax, e.g.:echo "match=$(...)" >> "$GITHUB_OUTPUT"
.
run: echo "::set-output name=match::$(echo '${{ github.ref }}' | grep -Pq '^refs/tags/v\d+\.\d+\.\d+$' && echo true || echo false)"
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
needs: build-package | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.