[release-3.4] Cleanup functional tests

[joshjms]

Adds the test-functional Makefile target.

Previously in .github/workflows/tests.yaml:

...
          linux-amd64-functional)
            ./build && GOARCH=amd64 PASSES='functional' ./test
            ;;
...

This is to standardize the commands used in the Prow job, we aim to simplify jobs to a single make [something] as much as possible.

/cc @ivanvc

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

[joshjms]

/hold

[joshjms]

/unhold

[joshjms]

/hold

[joshjms]

/unhold

[ivanvc]

LGTM. Thanks, @joshjms.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fuweid, ivanvc, joshjms
Once this PR has been reviewed and has the lgtm label, please assign jmhbnz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ivanvc]

Link to kubernetes/test-infra#32754

[serathius]

Note; functional tests were abandoned and removed because they didn't work and we didn't want to invest in them. They were replaced by robustness tests.

[serathius]

#15102

[joshjms]

Note; functional tests were abandoned and removed because they didn't work and we didn't want to invest in them. They were replaced by robustness tests.

Ah got it, then I think we can close this as we don't want any unnecessary tests in our CI? @ivanvc

[ivanvc]

Note; functional tests were abandoned and removed because they didn't work and we didn't want to invest in them. They were replaced by robustness tests.

@serathius, we're just closing the migration from GitHub workflows to Prow jobs. Note that this is for release-3.4. Do you suggest dropping these tests for release-3.4 (and release-3.5)?

[joshjms]

/test

[k8s-ci-robot]

@joshjms: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test pull-etcd-govulncheck

/test pull-etcd-integration-4-cpu-amd64

/test pull-etcd-release-tests

/test pull-etcd-verify

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[joshjms]

/test x

[k8s-ci-robot]

@joshjms: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-etcd-govulncheck

/test pull-etcd-integration-4-cpu-amd64

/test pull-etcd-release-tests

/test pull-etcd-verify

Use /test all to run all jobs.

In response to this:

/test x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[joshjms]

/test pull-etcd-integration-4-cpu-amd64

[serathius]

Note; functional tests were abandoned and removed because they didn't work and we didn't want to invest in them. They were replaced by robustness tests.

@serathius, we're just closing the migration from GitHub workflows to Prow jobs. Note that this is for release-3.4. Do you suggest dropping these tests for release-3.4 (and release-3.5)?

Functional tests were abandoned after v3.5 release as they were no bringing any value, we just forgot to remove them in older branches. Robustness tests on the main branch run against older etcd branches including release-3.4 and release-3.5. Therefore I think it's ok to remove them.

[ivanvc]

Functional tests were abandoned after v3.5 release as they were no bringing any value, we just forgot to remove them in older branches. Robustness tests on the main branch run against older etcd branches including release-3.4 and release-3.5. Therefore I think it's ok to remove them.

Thanks for the input. @joshjms, let's clean up instead, then.

[joshjms]

Got it will do @ivanvc

[joshjms]

Should we do a cleanup of this scale for a released branch or should we just remove the running of tests (without removing functional testing related things like the functional/ directory for example)

[ivanvc]

@joshjms, please only delete the GitHub workflow. Thanks.

[joshjms]

Got it, my bad

[ivanvc]

Ah, the workflow is shared with all the other tests. Let's delete them altogether then, when we finish the migration. Sorry about the confusion, and thanks, @joshjms.

[joshjms]

/retest

[joshjms]

Opening just to verify a presubmit

[ivanvc]

They work! Let's close this pull request. Thanks, @joshjms.

/close