-
Notifications
You must be signed in to change notification settings - Fork 10.1k
[release-3.4] Add grpcproxy Makefile targets #20063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-3.4] Add grpcproxy Makefile targets #20063
Conversation
Parallelize the grpcproxy tests. Refer to etcd-io#13657. Signed-off-by: joshjms <joshjms1607@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @joshjms.
/hold |
9f889b9
to
b9fbdc3
Compare
…ile targets Signed-off-by: joshjms <joshjms1607@gmail.com>
b9fbdc3
to
3a322e6
Compare
/unhold |
/retest |
/cc @jmhbnz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @joshjms
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivanvc, jmhbnz, joshjms The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test ? |
Separates the grpcproxy tests and adds the Makefile target for integration and e2e grpcproxy tests.
Ref: kubernetes/test-infra#32754
/cc @ivanvc @abdurrehman107
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.