Skip to content

[release-3.4] Add grpcproxy Makefile targets #20063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

joshjms
Copy link
Member

@joshjms joshjms commented May 30, 2025

Separates the grpcproxy tests and adds the Makefile target for integration and e2e grpcproxy tests.

Ref: kubernetes/test-infra#32754

/cc @ivanvc @abdurrehman107

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Parallelize the grpcproxy tests. Refer to etcd-io#13657.

Signed-off-by: joshjms <joshjms1607@gmail.com>
@joshjms joshjms changed the title Release 3.4 grpcproxy integration [release-3.4] Add grpcproxy Makefile targets May 30, 2025
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @joshjms.

@joshjms
Copy link
Member Author

joshjms commented May 30, 2025

/hold

@joshjms joshjms force-pushed the release-3.4-grpcproxy-integration branch 2 times, most recently from 9f889b9 to b9fbdc3 Compare May 30, 2025 18:49
…ile targets

Signed-off-by: joshjms <joshjms1607@gmail.com>
@joshjms joshjms force-pushed the release-3.4-grpcproxy-integration branch from b9fbdc3 to 3a322e6 Compare May 30, 2025 19:47
@joshjms
Copy link
Member Author

joshjms commented May 30, 2025

/unhold

@ivanvc
Copy link
Member

ivanvc commented May 30, 2025

/retest

@ivanvc
Copy link
Member

ivanvc commented May 30, 2025

/cc @jmhbnz

@k8s-ci-robot k8s-ci-robot requested a review from jmhbnz May 30, 2025 22:40
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @joshjms

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivanvc, jmhbnz, joshjms

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit 3e464b7 into etcd-io:release-3.4 Jun 2, 2025
25 of 27 checks passed
@joshjms
Copy link
Member Author

joshjms commented Jun 3, 2025

/test ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants