Skip to content

[release-3.4] Backport removing obsolete http 1.0 version for cmux tests #20136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2025

Conversation

joshjms
Copy link
Member

@joshjms joshjms commented Jun 6, 2025

Ensures tests to run successfully in Debian 12.

Partial backport of #16516.

/cc @ivanvc @jmhbnz

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Ensures tests to run successfully in Debian 12.

Partial backport of etcd-io#16516.

Signed-off-by: joshjms <joshjms1607@gmail.com>
@joshjms
Copy link
Member Author

joshjms commented Jun 6, 2025

Ref: #20116

@ivanvc
Copy link
Member

ivanvc commented Jun 6, 2025

Link to kubernetes/test-infra#32754

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @joshjms

@joshjms
Copy link
Member Author

joshjms commented Jun 6, 2025

It passes the e2e already, we can move forward to removing the tests.yaml file 🎉

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @joshjms.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & thx

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, jmhbnz, joshjms

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit e83c1a7 into etcd-io:release-3.4 Jun 7, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants