-
Notifications
You must be signed in to change notification settings - Fork 8
feat: Show image and other news on news pages #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for fipguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a new feature for news pages by showing an image and additional news items, and it includes a refactor from Bootstrap-based layout to custom SCSS. Key changes include new templates for news pages, layout adjustments for operator and country pages, and style updates using native media queries.
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
layouts/partials/internal_link.html | Added simple, self-contained internal link helper |
layouts/operator/single.html | Updated layout structure replacing Bootstrap grid |
layouts/news/single.html | New news page template displaying image and news list |
layouts/news/list.html | Introduced list view for news teasers |
layouts/country/single.html | Modified layout for country pages with simplified markup |
layouts/_default/single.html | Adjusted default template structure |
i18n/en.yaml & i18n/de.yaml | Updated translations for news-related keys |
assets/sass/* | Refactored SCSS to use native @media queries and grid layout |
CONTRIBUTING.md | Updated dependency reference from Bootstrap to pagefind |
23ad3a7
to
ab04bfa
Compare
ab04bfa
to
2d855be
Compare
Thanks for refactoring the sidebar, i like the new presentation of the single news!! :) – as mentioned in the files already, we should ask ourselves whether we should also use the bem-logic for consistency in new code. :) i´ve made some comments, it would be cool to take a look :) |
Thanks for the good review and being picky about applying BEM. I support the efforts to keep the code consistent and updated the newly introduced classes to BEM logic. Not 100% sure about |
81d7f02
to
d692c81
Compare
d692c81
to
c4b0071
Compare
c4b0071
to
310f870
Compare
310f870
to
ac4de6d
Compare
@therobrob can we merge this? |
@lenderom not yet. |
…ews-splitview # Conflicts: # assets/sass/sidemenu.scss # assets/sass/styles.scss # layouts/country/single.html # layouts/news/single.html # layouts/operator/single.html
On news pages, show the image and other news pages. On mobile devices, only the image is displayed.
While changing some parts, I refactored some code to use pure SCSS instead of bootstrap.
Resolves #144