Support intern-s1 #14875
Merged
Support intern-s1 #14875
+122
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CISC
reviewed
Jul 25, 2025
ngxson
requested changes
Jul 25, 2025
|
The |
@CISC hi, could you tell how to fix this error? Seems not reasonable to me |
Running llama.cpp/convert_hf_to_gguf.py Lines 3002 to 3005 in 5eba3e3 |
CISC
reviewed
Jul 30, 2025
ngxson
reviewed
Jul 30, 2025
ngxson
reviewed
Jul 30, 2025
CISC
reviewed
Jul 31, 2025
CISC
approved these changes
Aug 7, 2025
Comment on lines
+3208
to
+3211
| try: | ||
| self._set_vocab_sentencepiece() | ||
| except FileNotFoundError: | ||
| self._set_vocab_gpt2() |
There was a problem hiding this comment.
Suggested change
| try: | |
| self._set_vocab_sentencepiece() | |
| except FileNotFoundError: | |
| self._set_vocab_gpt2() | |
| super().set_vocab() |
Comment on lines
+3259
to
+3272
| special_tokens_map_file = self.dir_model / 'special_tokens_map.json' | ||
| additional_special_tokens = [] | ||
| if special_tokens_map_file.is_file(): | ||
| with open(special_tokens_map_file, encoding = 'utf-8') as f: | ||
| additional_special_tokens = json.load(f).get('additional_special_tokens', []) | ||
| tokenizer_cfg_file = self.dir_model / 'special_tokens_map.json' | ||
| if tokenizer_cfg_file.is_file(): | ||
| with open(tokenizer_cfg_file, encoding = 'utf-8') as f: | ||
| added_tokens_decoder = json.load(f).get('added_tokens_decoder', {}) | ||
| token2ids_map = {data['content'] : int(token) for token, data in added_tokens_decoder.items() if data['special']} | ||
| for token in additional_special_tokens: | ||
| if token in token2ids_map: | ||
| special_vocab._set_special_token(token, token2ids_map[token]) | ||
| special_vocab._set_special_token('eos', 151645) |
There was a problem hiding this comment.
Suggested change
| special_tokens_map_file = self.dir_model / 'special_tokens_map.json' | |
| additional_special_tokens = [] | |
| if special_tokens_map_file.is_file(): | |
| with open(special_tokens_map_file, encoding = 'utf-8') as f: | |
| additional_special_tokens = json.load(f).get('additional_special_tokens', []) | |
| tokenizer_cfg_file = self.dir_model / 'special_tokens_map.json' | |
| if tokenizer_cfg_file.is_file(): | |
| with open(tokenizer_cfg_file, encoding = 'utf-8') as f: | |
| added_tokens_decoder = json.load(f).get('added_tokens_decoder', {}) | |
| token2ids_map = {data['content'] : int(token) for token, data in added_tokens_decoder.items() if data['special']} | |
| for token in additional_special_tokens: | |
| if token in token2ids_map: | |
| special_vocab._set_special_token(token, token2ids_map[token]) | |
| special_vocab._set_special_token('eos', 151645) |
|
Can merge after changes and @ngxson approves. |
ngxson
approved these changes
Aug 7, 2025
|
Hmmm, after changes... :) |
|
woops sorry I missed that part. I guest @RunningLeon you need to open a new PR then |
the-phobos
pushed a commit
to the-phobos/llama.cpp
that referenced
this pull request
Aug 7, 2025
* support internvl * support interns1 * resolve comments * put interns1 in tensor mapping * resolve comment * move tokenizer changes to sub class
the-phobos
pushed a commit
to the-phobos/llama.cpp
that referenced
this pull request
Aug 7, 2025
* support internvl * support interns1 * resolve comments * put interns1 in tensor mapping * resolve comment * move tokenizer changes to sub class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support internlm/Intern-S1