Skip to content

Conversation

@snarfed
Copy link
Contributor

@snarfed snarfed commented Jul 9, 2025

for #122

@guillp one note here: this duplicates the existing code in AuthorizationRequestSerializer for [de]serializing DPoPKey. would you want a new DPoPKeySerializer class for that? I wasn't sure if you'd care more about the code duplication or the serializer class sprawl. I'm ok either way.

@codecov
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

❌ Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 99.94%. Comparing base (49f0739) to head (69e6107).

Files with missing lines Patch % Lines
requests_oauth2client/dpop.py 95.45% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #174      +/-   ##
===========================================
- Coverage   100.00%   99.94%   -0.06%     
===========================================
  Files           20       20              
  Lines         1974     1995      +21     
===========================================
+ Hits          1974     1994      +20     
- Misses           0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@snarfed
Copy link
Contributor Author

snarfed commented Jul 31, 2025

@guillp friendly ping? I'd love to get back to using requests_oauth2client from upstream here instead of my fork!...but I need this PR first.

@guillp
Copy link
Owner

guillp commented Sep 10, 2025

Hi @snarfed . This is not forgotten. But I didn't like to create 1 serializer class per token type. So I just started to refactor and improves all serializers in #196.

@snarfed snarfed force-pushed the dpop-token-serializer branch from 0ca1b1e to 69e6107 Compare September 13, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants