chore: Improving secret handling for BN chart deployments #1289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alfredo Gutierrez Grajeda <alfredo@hashgraph.com>
jsync-swirlds
approved these changes
Jun 11, 2025
AlfredoG87
added
the
Improvement
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #1289 +/- ##
============================================
+ Coverage 59.20% 59.24% +0.03%
- Complexity 949 951 +2
============================================
Files 152 152
Lines 5766 5766
Branches 573 573
============================================
+ Hits 3414 3416 +2
+ Misses 2173 2172 -1
+ Partials 179 178 -1 see 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer Notes
Due to how much Operators plan to deploy their BNs the best practice is to pre-create a secret source and then just specify it to the blockNode using a .Values override.
If for testing purposes still desires to create a secret object with entries provided in the collection of values, is still possible but discouraged other than for testing purposes
Fixes #1005
Fixes #999