Skip to content

chore: Improving secret handling for BN chart deployments #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025
Merged

chore: Improving secret handling for BN chart deployments #1289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion charts/block-node-server/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,13 @@ spec:
envFrom:
- configMapRef:
name: {{ include "hiero-block-node.fullname" . }}-config
{{ if .Values.blockNode.secret }}
- secretRef:
name: {{ include "hiero-block-node.fullname" . }}-secret
name: {{ include "hiero-block-node.fullname" . }}-secret
{{ else if .Values.blockNode.secretRef }}
- secretRef:
name: {{ .Values.blockNode.secretRef }}
{{ end }}
volumeMounts:
- name: logging-config
mountPath: {{ .Values.blockNode.logs.configMountPath }}
Expand Down
2 changes: 2 additions & 0 deletions charts/block-node-server/templates/secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{ if .Values.blockNode.secret }}
{{- /*
SPDX-License-Identifier: Apache-2.0
*/}}
Expand All @@ -11,3 +12,4 @@ data:
{{- range $key, $value := .Values.blockNode.secret }}
{{ $key }}: {{ $value | b64enc }}
{{- end }}
{{- end}}
7 changes: 5 additions & 2 deletions charts/block-node-server/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,11 @@ blockNode:
# this does not create a PVC.
# should match PERSISTENCE_STORAGE_UNVERIFIED_ROOT_PATH, leave as is for default.
mountPath: "/opt/hiero/block-node/data/unverified"
secret:
PRIVATE_KEY: "fake_private_key"
# For secrets, is recommended to use a secretRef to an existing secret on the cluster.
# secretRef: secret-name-reference
# not recommended to use this, but for testing purposes you can use the following collection for secrets auto-creation
# secret:
# EXAMPLE_SECRET: "FAKE EXAMPLE VALUE SECRET"
health:
readiness:
endpoint: "/healthz/readyz"
Expand Down
Loading