test: batch 2 conformity tests #4110
Conversation
Test Results 20 files ±0 265 suites ±0 18m 21s ⏱️ +7s For more details on these failures, see this check. Results for commit d922ece. ± Comparison against base commit a96d54d. This pull request removes 1 test.♻️ This comment has been updated with latest results. |
arianejasuwienas
force-pushed
the
3823-conformity-batch-2
branch
2 times, most recently
from
fc27453 to
c418d07
Compare
arianejasuwienas
force-pushed
the
3823-conformity-batch-2
branch
from
1fb8c97 to
c418d07
Compare
|
Looks like there's a lint issue. |
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
arianejasuwienas
force-pushed
the
3823-conformity-batch-2
branch
3 times, most recently
from
3ca251a to
13e8db2
Compare
| @@ -254,7 +240,7 @@ describe('@api-conformity', async function () { | |||
|
|
|||
| synthesizeTestCases(TEST_CASES_BATCH_3['server'], updateParamIfNeeded); | |||
|
|
|||
| describe('ws related rpc methods', async function () { | |||
| /* describe('ws related rpc methods', async function () { | |||
There was a problem hiding this comment.
is this supposed to be commented out? If yes, do we have an issue or PR to capture that some tests are skipped?
Maybe it's better to include .skip instead of commenting them,
There was a problem hiding this comment.
I’ll make sure they work correctly as well.
acuarica
changed the title
Yes, I just uncommented some previously commented code, but it’s a good chance to clean it up as well. |
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4110 +/- ##
==========================================
+ Coverage 95.39% 95.54% +0.14%
==========================================
Files 122 121 -1
Lines 20996 20163 -833
Branches 1750 1733 -17
==========================================
- Hits 20030 19265 -765
+ Misses 944 873 -71
- Partials 22 25 +3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Description
Batch 2 conformity tests - brought back.
Related issue(s)
Fixes #3823
Testing Guide
Changes from original design (optional)
Additional work needed (optional)
Checklist