feat: add GCP Pub/Sub destination support with configuration and credentials schemas #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Google Cloud Platform (GCP) Pub/Sub as a destination type, including comprehensive configuration and credentials schemas for the OpenAPI specification.
- Defines GCP Pub/Sub configuration schema with project ID, topic name, and optional endpoint
- Adds service account JSON credentials schema for authentication
- Integrates GCP Pub/Sub into polymorphic destination schemas for create, read, and update operations
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| DestinationGCPPubSub: | ||
| type: object | ||
| # Properties duplicated from DestinationBase | ||
| required: [id, type, topics, config, credentials, created_at, disabled_at] |
There was a problem hiding this comment.
The 'disabled_at' field should not be required since it can be null when the destination is enabled. Consider removing it from the required array or making it optional.
Suggested change
| required: [id, type, topics, config, credentials, created_at, disabled_at] | |
| required: [id, type, topics, config, credentials, created_at] |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
This is consistent with other destination types
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
leggetter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.