-
Notifications
You must be signed in to change notification settings - Fork 18
feat: add GCP Pub/Sub destination support with configuration and credentials schemas #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
586b189
fix(sdk): add missing status #490
obazoud 13f2414
feat: add GCP Pub/Sub destination support with configuration and cred…
leggetter 1d9027d
chore(docs): correct example syntax for S3 object key generation in O…
leggetter 2d44840
feat: use the SDK to test that the API is adhering to the OpenAPI con…
leggetter 1296b75
chore(tests): moved/deleted files
leggetter 8c954ee
chore(sdks): regeneration inc GCP Pub/Sub destination support
leggetter 4732d34
chore: add factory functions for various destination types and update…
leggetter f08eab4
chore: Add contract tests for various destination types: Azure Servic…
leggetter da18fa4
chore: Update test status report and skip tests for Hookdeck and AWS …
leggetter 01c451d
chore: Add comprehensive documentation and implementation roadmap for…
leggetter 1dacfec
Merge pull request #521 from hookdeck/feat/sdk-api-spec-tests
leggetter cd3fa35
Merge branch 'missing_status' into chore/openapi-add-gcppubsub
leggetter 1c733bc
fix: add status field to Event schema and comprehensive tests
leggetter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,94 @@ | ||
# OpenAPI Validation Test Suite - Implementation Plans | ||
|
||
This directory contains detailed planning documents for the next phases of the OpenAPI validation test suite project. | ||
|
||
## Current State (Completed) | ||
|
||
- ✅ **Test Suite**: 147 comprehensive tests across 8 destination types | ||
- ✅ **Test Results**: 129 passing tests (87.8% pass rate) | ||
- ✅ **Coverage**: All destination types tested (Webhook, AWS SQS, RabbitMQ, Azure Service Bus, AWS S3, Hookdeck, AWS Kinesis, GCP Pub/Sub) | ||
- ✅ **Documentation**: `TEST_STATUS.md` with detailed results and analysis | ||
- ✅ **Issue Tracking**: 3 GitHub issues created for backend improvements | ||
- ✅ **Test Infrastructure**: Factory pattern, SDK client utilities, comprehensive test suite | ||
|
||
## Next Phases | ||
|
||
This plan directory outlines the roadmap for enhancing the test suite with production-ready features: | ||
|
||
### 1. [CI/CD Integration](./01-ci-cd-integration.md) | ||
Automate test execution in GitHub Actions to ensure continuous validation of API endpoints against the OpenAPI specification. | ||
|
||
**Key Outcomes:** | ||
- Automated test runs on PRs and commits | ||
- Docker-based test environment | ||
- Test status badges | ||
- Failure notifications | ||
|
||
### 2. [Coverage Reporting](./02-coverage-reporting.md) | ||
Track and visualize which OpenAPI endpoints are tested, identify gaps, and enforce coverage thresholds. | ||
|
||
**Key Outcomes:** | ||
- Automated coverage reports | ||
- Visual coverage dashboards | ||
- Coverage trend tracking | ||
- Minimum coverage enforcement | ||
|
||
### 3. [Contributing Documentation](./03-contributing-docs.md) | ||
Provide clear guidelines for developers to add new tests and understand the testing architecture. | ||
|
||
**Key Outcomes:** | ||
- Updated CONTRIBUTING.md | ||
- Test development guide | ||
- Factory pattern documentation | ||
- Development workflow examples | ||
|
||
### 4. [Implementation Order](./04-implementation-order.md) | ||
Recommended sequence for implementing the above phases with effort estimates and success criteria. | ||
|
||
**Key Outcomes:** | ||
- Prioritized roadmap | ||
- Dependency mapping | ||
- Effort estimates | ||
- Success metrics | ||
|
||
## Plan Structure | ||
|
||
Each planning document follows this structure: | ||
|
||
1. **Overview** - Purpose and goals | ||
2. **Requirements** - Specific needs and constraints | ||
3. **Technical Approach** - Implementation details | ||
4. **Examples** - Code snippets and configurations | ||
5. **Acceptance Criteria** - Definition of done | ||
6. **Dependencies** - Related systems and prerequisites | ||
7. **Risks & Considerations** - Potential challenges | ||
|
||
## How to Use These Plans | ||
|
||
1. **Review** - Read through each plan to understand the scope | ||
2. **Prioritize** - Use `04-implementation-order.md` to sequence work | ||
3. **Implement** - Follow the technical approaches and examples | ||
4. **Validate** - Check against acceptance criteria | ||
5. **Iterate** - Update plans based on learnings | ||
|
||
## Related Documentation | ||
|
||
- [`/spec-sdk-tests/README.md`](../../spec-sdk-tests/README.md) - Test suite documentation | ||
- [`/spec-sdk-tests/TEST_STATUS.md`](../../spec-sdk-tests/TEST_STATUS.md) - Current test results | ||
- [`/docs/apis/openapi.yaml`](../../docs/apis/openapi.yaml) - OpenAPI specification | ||
- [`/CONTRIBUTING.md`](../../CONTRIBUTING.md) - General contribution guidelines | ||
|
||
## Feedback and Updates | ||
|
||
These plans are living documents. As implementation progresses: | ||
|
||
- Update plans with new learnings | ||
- Add implementation notes | ||
- Document deviations from original plan | ||
- Capture best practices discovered | ||
|
||
--- | ||
|
||
**Last Updated**: 2025-10-12 | ||
**Status**: Ready for implementation | ||
**Owner**: Engineering Team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'disabled_at' field should not be required since it can be null when the destination is enabled. Consider removing it from the required array or making it optional.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is consistent with other destination types