Fix TypeError: find_adapter_config_file() got an unexpected keyword argument '_adapter_model_path'

[albertvillanova]

Fix TypeError: find_adapter_config_file() got an unexpected keyword argument '_adapter_model_path'

• Pass original dict instead of copy to maybe_load_adapters

The adapter_kwargs is passed to maybe_load_adapters as unpacked keyword arguments: Python does not pass the original dictionary, but instead creates a new dictionary inside the function; so the pop inside the function does not have the intended behavior.

transformers/src/transformers/modeling_utils.py

Lines 4383 to 4387 in 5db7307

	_adapter_model_path, pretrained_model_name_or_path = maybe_load_adapters(
	pretrained_model_name_or_path,
	download_kwargs_with_commit,
	**adapter_kwargs,
	)

def maybe_load_adapters(
    pretrained_model_name_or_path,
    download_kwargs: DownloadKwargs,
    **adapter_kwargs,
):
    ...
    _adapter_model_path = adapter_kwargs.pop("_adapter_model_path", None)

This issue was introduced by PR:

• [from_pretrained] Small refactor from_pretrained: move around unrelated stuff #41445

Related downstream issue:

• CI fails with dev dependencies: TypeError: find_adapter_config_file() got an unexpected keyword argument '_adapter_model_path' trl#4273

[HuggingFaceDocBuilderDev]

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

[albertvillanova]

CC: @ArthurZucker (who opened the PR), @Cyrilvallez (who reviewed it).

[ArthurZucker]

LGTM, we are probably missing a test as the CI was full green on our side!

[BenjaminBossan]

I encountered this error in the PEFT CI, not sure if we need a separate test for this in transformers. Here is a minimal reproducer:

from transformers import AutoModelForCausalLM
model_id = "peft-internal-testing/opt-125m-dummy-lora"
AutoModelForCausalLM.from_pretrained(model_id)

I can confirm that this PR fixes the issue, but relying on the side effect of calling .pop on the original dict is maybe not the best solution IMO.

[albertvillanova]

Let me know if you would prefer that maybe_load_adapters returns a cleaned version of adapter_kwargs, besides current return values.

[BenjaminBossan]

Let me know if you would prefer that maybe_load_adapters returns a cleaned version of adapter_kwargs, besides current return values.

I think that's the cleaner solution but I'll leave the final decision to you / @ArthurZucker.