Skip to content

Fix TypeError: find_adapter_config_file() got an unexpected keyword argument '_adapter_model_path' #41604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+3 −3
Open

Fix TypeError: find_adapter_config_file() got an unexpected keyword argument '_adapter_model_path' #41604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
26fe1b3
Pass original dict instead of copy to maybe_load_adapters
albertvillanova Oct 15, 2025
a8bfe97
Merge branch 'main' into fix-type-error-adapter-model-path
ArthurZucker Oct 16, 2025
c620187
Revert "Pass original dict instead of copy to maybe_load_adapters"
albertvillanova Oct 19, 2025
601fb29
Return cleaned version of adapter_kwargs
albertvillanova Oct 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/transformers/integrations/peft.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,7 +628,7 @@ def maybe_load_adapters(
**adapter_kwargs,
):
if pretrained_model_name_or_path is None or not is_peft_available():
return None, pretrained_model_name_or_path
return None, pretrained_model_name_or_path, adapter_kwargs

token = download_kwargs.get("token")

Expand Down Expand Up @@ -670,4 +670,4 @@ def maybe_load_adapters(
_adapter_model_path = pretrained_model_name_or_path
pretrained_model_name_or_path = json.load(f)["base_model_name_or_path"]

return _adapter_model_path, pretrained_model_name_or_path
return _adapter_model_path, pretrained_model_name_or_path, adapter_kwargs
2 changes: 1 addition & 1 deletion src/transformers/modeling_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4381,7 +4381,7 @@ def from_pretrained(
if adapter_kwargs is None:
adapter_kwargs = {}

_adapter_model_path, pretrained_model_name_or_path = maybe_load_adapters(
_adapter_model_path, pretrained_model_name_or_path, adapter_kwargs = maybe_load_adapters(
pretrained_model_name_or_path,
download_kwargs_with_commit,
**adapter_kwargs,
Expand Down