Skip to content

Enable triton kernels matmul tests #5128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −4
Open

Enable triton kernels matmul tests #5128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/triton_kernels/triton_kernels/matmul_ogs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,7 +554,7 @@ def matmul_ogs(x, w, bias,
out_matmul_scale = out_matmul_scale.data.view(torch.uint8)
if has_scratchpad and "mx_out_scale" in memory["scratchpad"]:
out_matmul_scale = memory["scratchpad"]["mx_out_scale"]
out_matmul_has_mx = out_matmul_scale is not None and out_matmul.element_size() == 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for changing this line of code. This currently matches the upstream version of this file.

out_matmul_has_mx = out_matmul_scale is not None and bitwidth(out_dtype) == 8
# matrix multiplication
flex = precision_config.flex_ctx
bias_stride = None if bias is None else bias.stride(0)
Expand Down
1 change: 0 additions & 1 deletion scripts/skiplist/a770/triton_kernels.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
tests/test_matmul.py::test_op
tests/test_matmul.py::test_fused_act
tests/test_matmul.py::test_zero_reduction_dim
1 change: 0 additions & 1 deletion scripts/skiplist/arl-h/triton_kernels.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
tests/test_matmul.py::test_op
tests/test_matmul.py::test_fused_act
tests/test_matmul.py::test_zero_reduction_dim
1 change: 0 additions & 1 deletion scripts/skiplist/arl-s/triton_kernels.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
tests/test_matmul.py::test_op
tests/test_matmul.py::test_fused_act
tests/test_matmul.py::test_zero_reduction_dim
Loading