Skip to content

Conversation

whitneywhtsang
Copy link
Contributor

No description provided.

Signed-off-by: Whitney Tsang <whitney.tsang@intel.com>
@whitneywhtsang whitneywhtsang requested a review from etiotto October 1, 2025 16:00
@whitneywhtsang whitneywhtsang self-assigned this Oct 1, 2025
Copy link
Contributor

@etiotto etiotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a unit test.


// Check the constancy of the mask support to load the memory in 2D block.
if (!(maskConstancyHor >= instWidth && maskConstancyVer >= instHeight))
if (!(maskConstancyHor >= (tileWidth * numPackedVals) &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this equivalent to the code it replaces ?

@whitneywhtsang whitneywhtsang marked this pull request as draft October 2, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants