Skip to content

Conversation

whitneywhtsang
Copy link
Contributor

@whitneywhtsang whitneywhtsang commented Oct 1, 2025

Refactors the 2D block load lowering to simplify regular pointer load code generation.
The codegen now relies on linear layout and getBlockIOTileSize.

PVC: https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/18207021859 (GOOD)
BMG: https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/18207010226 (GOOD)

@whitneywhtsang whitneywhtsang self-assigned this Oct 1, 2025
@whitneywhtsang whitneywhtsang force-pushed the whitneywhtsang/loadoptoblockio branch 2 times, most recently from 6836bda to b362df6 Compare October 1, 2025 21:55
@whitneywhtsang whitneywhtsang requested a review from Copilot October 1, 2025 21:59
Signed-off-by: Whitney Tsang <whitney.tsang@intel.com>
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Refactors the 2D block load lowering to remove extensive DPAS-specific logic and simplify regular pointer load code generation. Key changes streamline mask constancy handling, compute load vector types directly, and introduce a new packing/unpacking path.

  • Removes the multi-step DPAS operand decomposition logic and associated comments.
  • Introduces a simplified computation of per-load element counts and restructuring of unpack/unpack insertion logic.
  • Updates tests to reflect new block IO tiling behavior (tile_height/v_blocks adjustments and mask index expectations).

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
third_party/intel/lib/TritonIntelGPUToLLVM/LoadStoreOpToLLVM.cpp Refactors 2D block load lowering: removes DPAS-specific tiling/packing logic, adds new per-load computation and unpack path, adjusts mask/vBlocks handling.
test/TritonIntelGPU/tensor-pointer-load-block-2d.mlir Updates CHECK patterns to match new tile shape, v_blocks, and constant/mask emission ordering.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@whitneywhtsang whitneywhtsang force-pushed the whitneywhtsang/loadoptoblockio branch 3 times, most recently from 27bfc77 to 4240852 Compare October 1, 2025 22:10
…ointer

Signed-off-by: Whitney Tsang <whitney.tsang@intel.com>
@whitneywhtsang whitneywhtsang force-pushed the whitneywhtsang/loadoptoblockio branch from 4240852 to ad3adb1 Compare October 1, 2025 22:17
Signed-off-by: Whitney Tsang <whitney.tsang@intel.com>
@whitneywhtsang whitneywhtsang requested a review from etiotto October 3, 2025 14:18
@etiotto etiotto requested a review from chengjunlu October 7, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant