Simplifies cross platform installation setup.py #3294
+75
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ooctipus
requested review from
hhansen-bdai,
Mayankm96 and
kellyguo11
as code owners
Mayankm96
reviewed
Aug 28, 2025
kellyguo11
reviewed
Aug 28, 2025
ooctipus
force-pushed
the
upstream/fix/robust_cross_platform_installation
branch
from
60c3c4c to
176ae7d
Compare
kellyguo11
changed the title
kellyguo11
approved these changes
Aug 29, 2025
Mayankm96
changed the title
Mayankm96
approved these changes
Sep 2, 2025
There was a problem hiding this comment.
Looks good overall.
Mostly wondering why are we enforcing torch via the install script and not the pyproject.toml file. I think back then the motivation was to force install a specific torch version (different from one shipped with IsaacSim). But is this still needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR
makes sure(skip if already satisfy, else install) the right torch is installed before and after pip installing isaaclab packages as sometime(rare case) due to flaky setup.py and unknown library dependencies changes pytorch version gets overriden.
only install pink and retargeters in linux x86 or amd64 machines
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there