Fixes missing visible attribute in spawn_ground_plane #3304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyguo11
requested review from
Mayankm96,
jtigue-bdai and
ooctipus
as code owners
Mayankm96
reviewed
Aug 29, 2025
| @@ -217,6 +217,10 @@ def spawn_ground_plane( | |||
| # create semantic type and data attributes | |||
| sem.CreateSemanticTypeAttr().Set(semantic_type) | |||
| sem.CreateSemanticDataAttr().Set(semantic_value) | |||
|
|
|||
| # Apply visibility | |||
| prim_utils.set_prim_property(prim_path, "visibility", "invisible" if not cfg.visible else "inherited") | |||
There was a problem hiding this comment.
I think there is a prim or stage utils that directly allows setting this. It's called set_prim_visibility.
There was a problem hiding this comment.
Indeed, updated to use the prim utils API
…cLab-public into fix/spawn-ground-visible
ooctipus
approved these changes
Aug 29, 2025
Mayankm96
approved these changes
Sep 1, 2025
ooctipus
pushed a commit
to ooctipus/IsaacLab
that referenced
this pull request
Sep 2, 2025
# Description `GroundPlaneCfg` allows for specifying `visible` parameter, but this would not being parsed in `spawn_ground_plane`, resulting in the parameter being a no-op when specified. This change adds a fix to parse the `visible` parameter from the cfg and sets the visibility attribute for the ground plane cfg appropriately. Fixes isaac-sim#3263 <!-- As a practice, it is recommended to open an issue to have discussions on the proposed pull request. This makes it easier for the community to keep track of what is being developed or added, and if a given feature is demanded by more than one party. --> ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GroundPlaneCfgallows for specifyingvisibleparameter, but this would not being parsed inspawn_ground_plane, resulting in the parameter being a no-op when specified. This change adds a fix to parse thevisibleparameter from the cfg and sets the visibility attribute for the ground plane cfg appropriately.Fixes #3263
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there