test juxt
#756
Merged
test juxt
#756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daveliepmann
force-pushed
the
test-juxt
branch
from
d126c9c to
2f8b271
Compare
jeaye
reviewed
Sep 9, 2025
| (is (= ["12345678910" 1 10] | ||
| ((juxt str min max) 1 2 3 4 5 6 7 8 9 10)))) | ||
|
|
||
| (testing "'returns a fn that is the juxtaposition of those fns'" |
There was a problem hiding this comment.
Thanks, Dave. The tests look good. One oddity stands out, though.
These four testing forms have double insulation of quoting. Was that intentional? I don't think we're using that anywhere else.
There was a problem hiding this comment.
Those are direct quotes from the docstring — intentional but could be more clear.
E-A-Griffin
reviewed
Sep 10, 2025
Co-authored-by: Emma Griffin <53583563+E-A-Griffin@users.noreply.github.com>
|
@daveliepmann if you give me write access to your fork I might be able to look into the issues here tomorrow morning before I go on vacation |
|
That way I can just push up a fix if I find one |
|
@E-A-Griffin you should have an invite now |
E-A-Griffin
approved these changes
Sep 12, 2025
|
Thanks, folks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #327