-
Notifications
You must be signed in to change notification settings - Fork 23
test juxt
#756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
test juxt
#756
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
(ns clojure.core-test.juxt | ||
(:require [clojure.test :as t :refer [deftest testing is are]] | ||
[clojure.core-test.portability #?(:cljs :refer-macros :default :refer) [when-var-exists]])) | ||
|
||
(when-var-exists juxt | ||
(deftest test-juxt | ||
(testing "'returns a function'" | ||
(is (ifn? (juxt juxt partial comp :foo))) | ||
(is (ifn? (juxt nil))) | ||
(is (ifn? (juxt (range))))) | ||
|
||
(testing "'the returned fn...returns a vector'" | ||
(is (vector? ((juxt inc) 5)))) | ||
|
||
(testing "'The returned fn takes a variable number of args'" | ||
(is (= ["12345678910" 1 10] | ||
((juxt str min max) 1 2 3 4 5 6 7 8 9 10)))) | ||
|
||
(testing "'returns a fn that is the juxtaposition of those fns'" | ||
(is (let [arg 10] | ||
(= (vector (inc arg) (dec arg) (identity arg)) | ||
((juxt inc dec identity) arg)))) | ||
(is (= ["foo" nil "bar"] | ||
((juxt :foo :missing :bar) {:foo "foo", :bar "bar"}))) | ||
(is (= [:namespace/keyword "keyword" "namespace"] | ||
((juxt identity name namespace) :namespace/keyword))) | ||
(is (= [:v] ((juxt {:k :v}) :k))) | ||
(is (= [:v] ((juxt :k) {:k :v}))) | ||
|
||
(is (= [:v :value "value"] | ||
((juxt {:k :v} | ||
#(get {:k :value} %) | ||
(fn [x] (get {:k "value"} x))) | ||
:k)))) | ||
|
||
(testing "wrong-shape input is mostly accepted (and throws when invoked)" | ||
(is (thrown? #?(:cljs :default, :clj java.lang.NullPointerException) | ||
((juxt nil)))) | ||
(is (thrown? #?(:cljs :default, :clj Exception) | ||
((juxt (range))))) | ||
(is (thrown? #?(:cljs :default, :clj Exception) | ||
((juxt 1))))))) | ||
daveliepmann marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Dave. The tests look good. One oddity stands out, though.
These four
testing
forms have double insulation of quoting. Was that intentional? I don't think we're using that anywhere else.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are direct quotes from the docstring — intentional but could be more clear.