fix: commit repository method wrong types #1752
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geclos
commented
Oct 2, 2025
| .limit(1) | ||
|
|
||
| return Result.ok(result[0]) | ||
| return result[0] as Commit | undefined |
There was a problem hiding this comment.
this can clearly be undefined yet types always asserted commit existed, for some reason
There was a problem hiding this comment.
Just don't do the as no? It will give drizzle schema or undefined
There was a problem hiding this comment.
for some reason it doesn't, not sure what is happening here
geclos
commented
Oct 2, 2025
| .orderBy(desc(commitsScope.mergedAt)) | ||
| .limit(1) | ||
|
|
||
| return Result.ok(result[0]) |
There was a problem hiding this comment.
do not return result objects in read methods
geclos
force-pushed
the
fix/commit_repository_wrong_types
branch
3 times, most recently
from
fa24012 to
d59759a
Compare
geclos
force-pushed
the
fix/commit_repository_wrong_types
branch
from
d59759a to
0efab52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.