-
Notifications
You must be signed in to change notification settings - Fork 42
Update docs contribution guide for two-repo setup #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to merge as-is, but wanted to make a couple of notes — could be fixed here or in follow-up PRs:
- I wasn't sure how to update the examples dir in the sphinx configuration, so currently the docs build actions manually copy the examples directory into this repo. Since this PR updates the sphinx config, perhaps it's worth updating the action as well? Or it might be worth splitting out that configuration update into a separate PR?
- I think many docs changes will be fine to make in the GH interface or a plaintext editor, but a really nice feature of jupytext is that it allows you to run the .md files from a Jupyter Lab or Jupyter Notebook interface. This is one of the main reasons why we went with myst-md rather than plain notebooks. I think we should explicitly encourage this way of writing docs, including a final clear+run-all, as the preferred mode of contribution. Again, this could be done in a follow-up.
Update: Just saw that this was done in #6. 🙏 But the deploy action and the action on the main repo still need to be updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick look, thanks for doing this, it looks great!
Thanks for the reviews folks - I will get to it as soon as possible. |
Build is failing because of the change noted here:
due to #8 |
dac1d32
to
932a952
Compare
Ok - I think this is a reasonable solution. If you clone both repos next to each other, nothing has changed and you can simply use
The github workflow has been updated accordingly as well. |
f358847
to
f6a4685
Compare
Hi folks, any feedback on the proposed solution here? @psobolewskiPhD @jni |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be clear, if I have this:
~/dev/napari/napari
~/dev/docs/docs
then everything works without the env var, but if I have some other combo, then need the env var?
Yes - the current relevant snippet from the Makefile is
So if the repos are cloned "next to each other", all should be good. |
f6a4685
to
1c7fd37
Compare
❤️ 🚀 |
Description
Updates the docs contribution guide to match the new documentation setup.
Also some light copyediting of the content.
Type of change
References
Closes #3
How has this been tested?
Final checklist:
trans.
to make them localizable.For more information see our translations guide.