Skip to content

fix: use >| instead of > #8476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: use >| instead of > #8476

wants to merge 2 commits into from

Conversation

znorgaard
Copy link
Contributor

@znorgaard znorgaard commented May 14, 2025

See issue for details. tldr > > redirect pattern can count as a clobber in some environments / with certain versions of bash. Using >| > temporarily ignores the clobber check.

I also needed to fix the rseqc env files to get linting to pass, conda-forge::r-base>=3.5 -> conda-forge::r-base=3.5

PR checklist

Closes #8455

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@znorgaard znorgaard requested a review from edmundmiller as a code owner May 14, 2025 20:49
@znorgaard
Copy link
Contributor Author

[In progress]

Modules failing testing due to nextflow-io/nextflow#5456

  • angsd/contamination docker test: reproduced locally. It's specifically the stub test that fails. conda env with nextflow=24.10.2 nf-test=0.9.2 causes failure. Using latest of both the test passes. nf-test test --profile "docker" --verbose modules/nf-core/angsd/contamination/tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modules using log redirects break when using conda
1 participant