-
Notifications
You must be signed in to change notification settings - Fork 934
Merge modules with new topics syntax #9333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mashehu
wants to merge
13
commits into
master
Choose a base branch
from
topics-adoption
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* topics bismark/align * fix versions command --------- Co-authored-by: Marcel Ribeiro-Dantas <marcel.ribeirodantas@seqera.io>
* Converts FASTQ to use topics for version Fixes #9261 * Updates meta.yml file * Updates snapshot * Update modules/nf-core/fastqc/main.nf Co-authored-by: Nicolas Vannieuwkerke <101190534+nvnieuwk@users.noreply.github.com> * Update modules/nf-core/fastqc/meta.yml Co-authored-by: Nicolas Vannieuwkerke <101190534+nvnieuwk@users.noreply.github.com> * Updates snapshot * Removes .mix versions of FASTQ in subworkflows * Updates snapshots of fastqc modules and related subworkflows * Updates snapshots of fastqc * Updates fastqc snapshot * Sanitizes process.out for indexed outputs * Updates fastqc snapshot * Updates fastqc snapshot * Adds topic to the meta.yml file * Fixes syntax usage of topic * Adds new Devcontainer Setup for use with Codespaces (#8983) * Add devcontainer setup from nf-core/tools for testing. Move nf-test install to setup.sh * Add the default user again at the end * Move nf-test install to unprivileged location and add WORKDIR. Add pipefail. Remove copying unnecessary files. * Move Dockerfile * Remove docker-in-docker interfering with docker-outside-docker from parent image. Adapt Mounts to use host paths when starting sibling containers * Fix arm profile * Remove apptainer install * Remove efforts for unprivileged user * Use root user by default * update welcome message. update prompt * Remove explicitly setting NFT_WORKDIR * Add nf-test as local feature * Remove Dockerfile in favor of features * Remove env vars * Add apptainer as local feature * Fix install * Fix install script for apptainer by installing dependencies first * Fix install script for apptainer by installing dependencies first * Update local feature to have version, name, id * ftr: new devcontainer config * Remove redundant tools install * Remove local features. Already installed in parent image * Testing: Change to pulling image from controlled location for testing in codespaces. REVERT THIS * fix: set executable bit flag to run setup.sh * Change to final container image * Bumpy hostRequirements to run in more powerful instance in Codespaces * Switch to using dev tag of our nf-core/devcontainer * Fixes meta.yml file indenting + syntax * Fixes meta.yml with nf-core modules lint fastqc --fix * Removes accidental adding of .devcontainer * Fixes null version in subworkflow snapshot --------- Co-authored-by: Nicolas Vannieuwkerke <101190534+nvnieuwk@users.noreply.github.com> Co-authored-by: JulianFlesch <julianflesch@googlemail.com>
* update multiqc to use topics for versions * update nf-test and snapshots * update meta.yml * update main.nf.test after review * removed and re-generated main.nf.test.snap after changes * Fixing remarks * Fix failing linting tests --------- Co-authored-by: Marcel Ribeiro-Dantas <marcel.ribeirodantas@seqera.io>
* add versions topic to trinity module * add missing test for main.nf.test * simplify string replacement for trinity version eval to remove use of colons - avoids potential yml clash * update meta.yml to capture new version topics change * add new test for aggregating versions via topic * update snapshot for new tests * Update modules/nf-core/trinity/meta.yml remove leading space Co-authored-by: Nicolas Vannieuwkerke <101190534+nvnieuwk@users.noreply.github.com> --------- Co-authored-by: Nicolas Vannieuwkerke <101190534+nvnieuwk@users.noreply.github.com>
* adding topics channel * nf-test * lint meta yml * redo meta.yml * remove dup * remove tabix version * remove tabix versions from subworkflows * fix test * update snapshot * fix snapshots subworkflows * missed one subworkflow * more subworkflows * last (?) subworkflow * harshils alignmnent * too enthusiatic when removing * snaphots because bgzip versions are back * fix topics syntax for linting * Revert "fix topics syntax for linting" This reverts commit 0d25630. * version syntax changed in test * remove newline * Update modules/nf-core/tabix/tabix/main.nf Co-authored-by: Nicolas Vannieuwkerke <101190534+nvnieuwk@users.noreply.github.com> * Update modules/nf-core/tabix/tabix/meta.yml Co-authored-by: Nicolas Vannieuwkerke <101190534+nvnieuwk@users.noreply.github.com> * snapshot for new version_tabix name --------- Co-authored-by: mapo9 <mark.poslter@qbic.uni-tuebingen.de> Co-authored-by: Marcel Ribeiro-Dantas <marcel.ribeirodantas@seqera.io> Co-authored-by: Nicolas Vannieuwkerke <101190534+nvnieuwk@users.noreply.github.com>
* topics bamstats generalstats * fix version * update samtools/view to use topics
* feat: update samtools sort module with version topic support * feat: update samtools sort module with version topic support * feat: update samtools sort module with version topic support * feat: update samtools sort module with version topic support * feat: update samtools sort module with version topic support * feat: update samtools sort module with version topic support * feat: update samtools sort module with version topic support * Update meta.yml and test snapshot * remove .devcontainer * Revert "remove .devcontainer" This reverts commit a97a7a2. --------- Co-authored-by: Marcel Ribeiro-Dantas <marcel@seqera.io> Co-authored-by: Marcel Ribeiro-Dantas <marcel.ribeirodantas@seqera.io>
* Adds version topic channel to SAMTOOLS_STATS * Removes version mix in subworkflow * Removes version mix for samtools sort * Updates snapshots for tests * Update modules/nf-core/samtools/stats/main.nf Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com> * Update modules/nf-core/samtools/stats/meta.yml Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com> * Fixes meta.yml * [automated] Update gpu snapshot * [automated] Update gpu snapshot * remove accidentally added file --------- Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com> Co-authored-by: nf-core-bot <core@nf-co.re> Co-authored-by: mashehu <mashehu3@gmail.com>
Member
|
@nf-core-bot update snapshot path: subworkflows/nf-core/fastq_align_bowtie2 |
Member
|
@nf-core-bot update snapshot path: subworkflows/nf-core/bam_split_by_region |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://deploy-preview-3613--nf-core-main-site.netlify.app/blog/2025/version_topics for details about this effort