-
Notifications
You must be signed in to change notification settings - Fork 18
ENH: Implement X5 representation and output to filesystem #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Implement X5 representation and output to filesystem #241
Conversation
(cherry picked from commit 49bf4c3)
(cherry picked from commit 74090ac)
(cherry picked from commit ba8a389)
(cherry picked from commit e4e3f44)
…s to the future. Started the beginning of some xfm_utils for quicker testing and validation. (cherry picked from commit 7ba96c3)
(cherry picked from commit 0e213cb)
(cherry picked from commit 3d263bb)
(cherry picked from commit a102f1e)
(cherry picked from commit e465332)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #241 +/- ##
==========================================
+ Coverage 95.38% 95.55% +0.17%
==========================================
Files 28 30 +2
Lines 2948 3063 +115
==========================================
+ Hits 2812 2927 +115
Misses 136 136
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5dc7281
to
bcbadda
Compare
6ffc445
to
740a0c4
Compare
de96326
to
6ec566f
Compare
I'm going to misbehave and merge this without the necessary review, in part to be respectful of the well-deserved break some are taking. This is relatively safe (in that it only adds support for X5 and removes brittle code), and it builds upon prior work within #213. I've tried to credit that work by manually setting co-authorship of commits :) |
22490db
to
d9dbd6f
Compare
Resolves: #111. Co-authored-by: Julien Marabotto <166002186+jmarabotto@users.noreply.github.com> Co-authored-by: sgiavasis <sgiava77@gmail.com>
d9dbd6f
to
ce1083c
Compare
Co-authored-by: Julien Marabotto <166002186+jmarabotto@users.noreply.github.com> Co-authored-by: sgiavasis <sgiava77@gmail.com>
Building on top of #213 and #241, this PR adds a baseline implementation for BIDS' X5.
@sgiavasis, @jmarabotto: I tried to cherry-pick everything you did within the other PR, and pushed your branch for reference to the upstream repository. In a second pass after this PR, I want to review how much from outside
nitransforms.io
needs to be picked up back.