ENH: Implement X5 representation and output to filesystem #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 49bf4c3)
(cherry picked from commit 74090ac)
(cherry picked from commit ba8a389)
(cherry picked from commit e4e3f44)
…s to the future. Started the beginning of some xfm_utils for quicker testing and validation. (cherry picked from commit 7ba96c3)
(cherry picked from commit 0e213cb)
(cherry picked from commit 3d263bb)
(cherry picked from commit a102f1e)
(cherry picked from commit e465332)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #241 +/- ##
==========================================
+ Coverage 95.38% 95.55% +0.17%
==========================================
Files 28 30 +2
Lines 2948 3063 +115
==========================================
+ Hits 2812 2927 +115
Misses 136 136
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oesteban
force-pushed
the
codex/create-x5transform-dataclass-in-nitransforms.io.x5
branch
from
5dc7281 to
bcbadda
Compare
oesteban
force-pushed
the
codex/create-x5transform-dataclass-in-nitransforms.io.x5
branch
from
6ffc445 to
740a0c4
Compare
oesteban
changed the title
oesteban
force-pushed
the
codex/create-x5transform-dataclass-in-nitransforms.io.x5
branch
3 times, most recently
from
de96326 to
6ec566f
Compare
|
I'm going to misbehave and merge this without the necessary review, in part to be respectful of the well-deserved break some are taking. This is relatively safe (in that it only adds support for X5 and removes brittle code), and it builds upon prior work within #213. I've tried to credit that work by manually setting co-authorship of commits :) |
oesteban
force-pushed
the
codex/create-x5transform-dataclass-in-nitransforms.io.x5
branch
3 times, most recently
from
22490db to
d9dbd6f
Compare
Resolves: #111. Co-authored-by: Julien Marabotto <166002186+jmarabotto@users.noreply.github.com> Co-authored-by: sgiavasis <sgiava77@gmail.com>
oesteban
force-pushed
the
codex/create-x5transform-dataclass-in-nitransforms.io.x5
branch
from
d9dbd6f to
ce1083c
Compare
Co-authored-by: Julien Marabotto <166002186+jmarabotto@users.noreply.github.com> Co-authored-by: sgiavasis <sgiava77@gmail.com>
oesteban
deleted the
codex/create-x5transform-dataclass-in-nitransforms.io.x5
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on top of #213 and #241, this PR adds a baseline implementation for BIDS' X5.
@sgiavasis, @jmarabotto: I tried to cherry-pick everything you did within the other PR, and pushed your branch for reference to the upstream repository. In a second pass after this PR, I want to review how much from outside
nitransforms.ioneeds to be picked up back.