CONSOLE-4765, CONSOLE-4767: Automate console tech preview flag via cluster FeatureSet, Grant console service account watch permissions for ClusterCatalogs #1043

TheRealJon · 2025-09-09T21:19:29Z

This PR implements two stories:

CONSOLE-4765: Automate console tech preview flag via cluster FeatureSet

Implement automatic enabling of console tech preview features when the cluster FeatureSet is configured to TechPreviewNoUpgrade. The console operator now monitors the cluster's FeatureGate resource and sets the TechPreviewEnabled flag in the console-config ConfigMap accordingly.

Key changes:

Add FeatureGate informer to console operator
Implement SyncTechPreview function following established patterns
Add TechPreviewEnabled field to ClusterInfo in console config
Update config builder to support tech preview flag
Add comprehensive test coverage

CONSOLE-4767: Grant console service account watch permissions for ClusterCatalogs

Add get, list, and watch permissions for clustercatalogs in the operators.coreos.com
API group to the console ClusterRole. This enables the console backend to monitor
ClusterCatalog resources in real-time and provide accurate OperatorHub status updates.

🤖 Generated with Claude Code

Implement automatic enabling of console tech preview features when the cluster FeatureSet is configured to TechPreviewNoUpgrade. The console operator now monitors the cluster's FeatureGate resource and sets the TechPreviewEnabled flag in the console-config ConfigMap accordingly. Key changes: - Add FeatureGate informer to console operator - Implement SyncTechPreview function following established patterns - Add TechPreviewEnabled field to ClusterInfo in console config - Update config builder to support tech preview flag - Add comprehensive test coverage 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

openshift-ci-robot · 2025-09-09T21:19:35Z

@TheRealJon: This pull request references CONSOLE-4765 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Implement automatic enabling of console tech preview features when the cluster FeatureSet is configured to TechPreviewNoUpgrade. The console operator now monitors the cluster's FeatureGate resource and sets the TechPreviewEnabled flag in the console-config ConfigMap accordingly.

Key changes:

Add FeatureGate informer to console operator

Implement SyncTechPreview function following established patterns

Add TechPreviewEnabled field to ClusterInfo in console config

Update config builder to support tech preview flag

Add comprehensive test coverage

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-09-09T21:27:33Z

@TheRealJon: This pull request references CONSOLE-4765 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

This pull request references CONSOLE-4767 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Implement automatic enabling of console tech preview features when the cluster FeatureSet is configured to TechPreviewNoUpgrade. The console operator now monitors the cluster's FeatureGate resource and sets the TechPreviewEnabled flag in the console-config ConfigMap accordingly.

Key changes:

Add FeatureGate informer to console operator

Implement SyncTechPreview function following established patterns

Add TechPreviewEnabled field to ClusterInfo in console config

Update config builder to support tech preview flag

Add comprehensive test coverage

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

TheRealJon · 2025-09-09T21:31:29Z

/hold

Test with openshift/console#15477 and openshift/console#15466

…sterCatalogs Add get, list, and watch permissions for clustercatalogs in the operators.coreos.com API group to the console ClusterRole. This enables the console backend to monitor ClusterCatalog resources in real-time and provide accurate OperatorHub status updates. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

openshift-ci-robot · 2025-09-10T15:51:27Z

@TheRealJon: This pull request references CONSOLE-4765 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

This pull request references CONSOLE-4767 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

This PR implements two stories:

CONSOLE-4765: Automate console tech preview flag via cluster FeatureSet

Implement automatic enabling of console tech preview features when the cluster FeatureSet is configured to TechPreviewNoUpgrade. The console operator now monitors the cluster's FeatureGate resource and sets the TechPreviewEnabled flag in the console-config ConfigMap accordingly.

Key changes:

Add FeatureGate informer to console operator

Implement SyncTechPreview function following established patterns

Add TechPreviewEnabled field to ClusterInfo in console config

Update config builder to support tech preview flag

Add comprehensive test coverage

CONSOLE-4767: Grant console service account watch permissions for ClusterCatalogs

Add get, list, and watch permissions for clustercatalogs in the operators.coreos.com
API group to the console ClusterRole. This enables the console backend to monitor
ClusterCatalog resources in real-time and provide accurate OperatorHub status updates.

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

TheRealJon · 2025-09-11T16:57:29Z

/unhold

TheRealJon · 2025-09-12T15:35:04Z

QE Approver
/assign @yapei

Docs Approver:
/assign @jseseCCS

PX Approver:
/assign @sferich888

openshift-ci · 2025-09-12T15:35:09Z

@TheRealJon: GitHub didn't allow me to assign the following users: jseseCCS.

Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

QE Approver
/assign @yapei

Docs Approver:
/assign @jseseCCS

PX Approver:
/assign @sferich888

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

yapei · 2025-09-15T07:50:01Z

verified the PR changes with following test scenarios

when TechPreviewNoUpgrade is enabled(FeatureGate.spec.featureSet == TechPreviewNoUpgrade), cm/console-config will be updated with techPreviewEnabled: true in clusterInfo
console pods will log warn info when TechPreviewNoUpgrade is enabled

/verified by @yapei

openshift-ci-robot · 2025-09-15T07:50:16Z

@yapei: This PR has been marked as verified by @yapei.

In response to this:

verified the PR changes with following test scenarios

when TechPreviewNoUpgrade is enabled(FeatureGate.spec.featureSet == TechPreviewNoUpgrade), cm/console-config will be updated with techPreviewEnabled: true in clusterInfo

console pods will log warn info when TechPreviewNoUpgrade is enabled

/verified by @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sferich888 · 2025-09-16T19:45:19Z

/label px-approved

jseseCCS

back to you @TheRealJon

pkg/console/operator/sync_v400.go

pkg/console/subresource/configmap/tech_preview_test.go

jseseCCS · 2025-09-17T19:25:14Z

/label docs-approved

TheRealJon · 2025-09-17T19:32:46Z

@yapei @Leo6Leo Do you mind taking another look after the recent feedback changes?

openshift-ci · 2025-09-17T23:24:28Z

@TheRealJon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

yapei · 2025-09-18T03:25:33Z

verified with latest changes, it looks good

$ oc patch  featuregate cluster -p '{"spec": {"featureSet": "TechPreviewNoUpgrade"}}' --type merge
featuregate.config.openshift.io/cluster patched
$ oc get cm console-config -n openshift-console -o yaml | grep clusterInfo -A10
    clusterInfo:
      consoleBaseAddress: https://console-openshift-console.apps.ci-ln-h9qi0rb-76ef8.aws-2.ci.openshift.org
      controlPlaneTopology: HighlyAvailable
      masterPublicURL: https://api.ci-ln-h9qi0rb-76ef8.aws-2.ci.openshift.org:6443
      nodeArchitectures:
      - amd64
      nodeOperatingSystems:
      - linux
      releaseVersion: 4.21.0-0-2025-09-18-021036-test-ci-ln-h9qi0rb-latest
      techPreviewEnabled: true
    contentSecurityPolicyEnabled: true
$ oc logs console-6755cd4bc5-572jk -n openshift-console
W0918 03:17:33.324010       1 main.go:183] Technology Preview features are enabled. These features are experimental and not supported for production use. If you encounter issues, send feedback through the usual support or bug-reporting channels.
I0918 03:17:33.324044       1 main.go:264] Console plugins are enabled in following order:
......................................................
$  oc logs console-operator-75486874fb-qfbbl  -n openshift-console-operator | grep -i "tech.*preview"
I0918 03:17:04.516651       1 sync_v400.go:575] Console Technology Preview features enabled based on cluster FeatureSet TechPreviewNoUpgrade.
I0918 03:17:05.442203       1 sync_v400.go:575] Console Technology Preview features enabled based on cluster FeatureSet TechPreviewNoUpgrade.
I0918 03:17:06.444818       1 sync_v400.go:575] Console Technology Preview features enabled based on cluster FeatureSet TechPreviewNoUpgrade.
....................................

Leo6Leo

Thanks @TheRealJon , i don't see any big issues with the PR, but I do have few questions that will be worthy for considering. Please see the comments on the PR and let me know how do you think.

Leo6Leo · 2025-09-18T18:46:24Z

pkg/console/operator/sync_v400.go

+	techPreviewEnabled, techPreviewErrReason, techPreviewErr := co.SyncTechPreview()
+	statusHandler.AddConditions(status.HandleProgressingOrDegraded("TechPreviewSync", techPreviewErrReason, techPreviewErr))
+	if techPreviewErr != nil {
+		return statusHandler.FlushAndReturn(techPreviewErr)


It seems like the error return here will cause the whole sync to terminate and exit. Will that be okay? If the techPreview is not a core console necessity. I saw customLogosErr in the few lines above is implemented like this way too, so I would assume it should be fine?

Yeah, this is a pattern used throughout our operator. It is signaling that there is something wrong with either our operator or the cluster configuration. When our operator is unable to sync something, it should indicate that it is degraded in it's conditions.

Leo6Leo · 2025-09-18T18:50:04Z

pkg/console/operator/sync_v400.go

+	}
+
+	techPreviewEnabled = featureGate.Spec.FeatureSet == configv1.TechPreviewNoUpgrade
+


Should we add something like this, to log when there are changes to the TechPreview mode (i.e. being toggled)

We aren't very consistent on this, and more frequently don't do this as far as I can tell.

Leo6Leo · 2025-09-18T18:51:29Z

manifests/03-rbac-role-cluster.yaml

      - validatingwebhookconfigurations
    verbs:
      - get
+  - apiGroups:


Are there any documentations or note we need to update to reflect this role change?

None that I know of.

TheRealJon · 2025-09-19T14:53:26Z

verified with latest changes, it looks good

/verified by @yapei
/label qe-approved

openshift-ci-robot · 2025-09-19T14:53:38Z

@TheRealJon: This PR has been marked as verified by @yapei.

In response to this:

verified with latest changes, it looks good

/verified by @yapei
/label qe-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-09-19T14:53:46Z

@TheRealJon: This pull request references CONSOLE-4765 which is a valid jira issue.

This pull request references CONSOLE-4767 which is a valid jira issue.

In response to this:

This PR implements two stories:

CONSOLE-4765: Automate console tech preview flag via cluster FeatureSet

Implement automatic enabling of console tech preview features when the cluster FeatureSet is configured to TechPreviewNoUpgrade. The console operator now monitors the cluster's FeatureGate resource and sets the TechPreviewEnabled flag in the console-config ConfigMap accordingly.

Key changes:

Add FeatureGate informer to console operator

Implement SyncTechPreview function following established patterns

Add TechPreviewEnabled field to ClusterInfo in console config

Update config builder to support tech preview flag

Add comprehensive test coverage

CONSOLE-4767: Grant console service account watch permissions for ClusterCatalogs

Add get, list, and watch permissions for clustercatalogs in the operators.coreos.com
API group to the console ClusterRole. This enables the console backend to monitor
ClusterCatalog resources in real-time and provide accurate OperatorHub status updates.

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Leo6Leo · 2025-09-22T13:44:37Z

Thanks @TheRealJon for the clarification, and everything makes sense to me. And all the tests are passing without any issues. Therefore, LGTM!

/lgtm

openshift-ci · 2025-09-22T13:45:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leo6Leo, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [TheRealJon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 9, 2025

openshift-ci bot requested review from jhadvig and spadgett September 9, 2025 21:20

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2025

TheRealJon changed the title ~~CONSOLE-4765: Automate console tech preview flag via cluster FeatureSet~~ CONSOLE-4765, CONSOLE-4767: Automate console tech preview flag via cluster FeatureSet, Grant console service account watch permissions for ClusterCatalogs Sep 9, 2025

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2025

TheRealJon mentioned this pull request Sep 9, 2025

CONSOLE-4764: Add tech preview feature flag support openshift/console#15477

Merged

TheRealJon force-pushed the CONSOLE-4765 branch from 73466ee to 4fcebc5 Compare September 10, 2025 15:49

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2025

openshift-ci bot assigned sferich888 and yapei Sep 12, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 15, 2025

openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Sep 16, 2025

jseseCCS suggested changes Sep 17, 2025

View reviewed changes

reword log messages based on PR feedback

541a4ae

openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Sep 17, 2025

openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Sep 17, 2025

add missing periods

2eecdf6

Leo6Leo reviewed Sep 18, 2025

View reviewed changes

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 19, 2025

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 19, 2025

openshift-ci bot assigned Leo6Leo Sep 22, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2025

openshift-merge-bot bot merged commit ca22e61 into openshift:main Sep 22, 2025
13 checks passed

TheRealJon deleted the CONSOLE-4765 branch September 22, 2025 13:50

		}

		techPreviewEnabled = featureGate.Spec.FeatureSet == configv1.TechPreviewNoUpgrade

CONSOLE-4765, CONSOLE-4767: Automate console tech preview flag via cluster FeatureSet, Grant console service account watch permissions for ClusterCatalogs #1043

CONSOLE-4765, CONSOLE-4767: Automate console tech preview flag via cluster FeatureSet, Grant console service account watch permissions for ClusterCatalogs #1043

Uh oh!

Conversation

TheRealJon commented Sep 9, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CONSOLE-4765: Automate console tech preview flag via cluster FeatureSet

CONSOLE-4767: Grant console service account watch permissions for ClusterCatalogs

Uh oh!

openshift-ci-robot commented Sep 9, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 9, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TheRealJon commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 10, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CONSOLE-4765: Automate console tech preview flag via cluster FeatureSet

CONSOLE-4767: Grant console service account watch permissions for ClusterCatalogs

Uh oh!

TheRealJon commented Sep 11, 2025

Uh oh!

TheRealJon commented Sep 12, 2025

Uh oh!

openshift-ci bot commented Sep 12, 2025

Uh oh!

yapei commented Sep 15, 2025

Uh oh!

openshift-ci-robot commented Sep 15, 2025

Uh oh!

sferich888 commented Sep 16, 2025

Uh oh!

jseseCCS left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jseseCCS commented Sep 17, 2025

Uh oh!

TheRealJon commented Sep 17, 2025

Uh oh!

openshift-ci bot commented Sep 17, 2025

Uh oh!

yapei commented Sep 18, 2025

Uh oh!

Leo6Leo left a comment

Choose a reason for hiding this comment

Uh oh!

Leo6Leo Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

TheRealJon Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

Leo6Leo Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

TheRealJon Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

Leo6Leo Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

TheRealJon Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

TheRealJon commented Sep 19, 2025

Uh oh!

openshift-ci-robot commented Sep 19, 2025

Uh oh!

openshift-ci-robot commented Sep 19, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CONSOLE-4765: Automate console tech preview flag via cluster FeatureSet

CONSOLE-4767: Grant console service account watch permissions for ClusterCatalogs

Uh oh!

TheRealJon commented Sep 9, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Sep 9, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Sep 9, 2025 •

edited by openshift-ci bot

Loading

TheRealJon commented Sep 9, 2025 •

edited

Loading

openshift-ci-robot commented Sep 10, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Sep 19, 2025 •

edited by openshift-ci bot

Loading