OPRUN-4086: Add ClusterCatalog controller #15466
Conversation
openshift-ci
bot
added
component/backend
|
Hi @trgeiger. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
|
do not merge until we add tech preview feature flag support to console--I will then wrap all this functionality in that feature flag |
| // The ClusterCatalog has been found on the cluster, add to or update cache | ||
| baseURL := clusterCatalog.Status.URLs.Base | ||
|
|
||
| if baseURL != "" { |
There was a problem hiding this comment.
Is this Status.URLs.Base a required property in the ClusterCatalog API? If not, should we add a debug-level log message when it's missing?
There was a problem hiding this comment.
I think URLs is not required but if it exists, Base is a required field on a URL. So yeah I'll add some logic for catching that.
- Use klog for logging - Handle missing URLs or Base fields - Check err when creating controller manager
Default to :8081 to avoid collision with existing metrics endpoint at :8080.
trgeiger
force-pushed
the
solo-catalog-controller
branch
from
1e49535 to
0dafc53
Compare
trgeiger
force-pushed
the
solo-catalog-controller
branch
from
0dafc53 to
c3ea325
Compare
|
QE Approver Docs Approver: PX Approver: |
|
@TheRealJon: GitHub didn't allow me to assign the following users: jseseCCS. Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TheRealJon, trgeiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
trgeiger
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@trgeiger: This pull request references OPRUN-4086 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
New changes are detected. LGTM label has been removed. |
trgeiger
force-pushed
the
solo-catalog-controller
branch
2 times, most recently
from
d9b60b8 to
81ce7c3
Compare
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
trgeiger
force-pushed
the
solo-catalog-controller
branch
from
81ce7c3 to
2f29492
Compare
|
@trgeiger: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/assign @bandrade |
Adds a controller for reconciling ClusterCatalogs. Currently it uses a dummy "CatalogService" that doesn't actually do anything.
This is a reformatting and cherry-pick of commits in this draft PR so we can land the controller first and iterate on its functionality in a future PR to add the actual CatalogService implementation and front-end/handler logic.
Vendor and dependency updates are in their own commit to make it easier to review the actual code changes.
The work for creating this controller is tracked in OPRUN-4086.