Skip to content

fix: minikube setup does not use github token #2874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 21, 2025
Merged

fix: minikube setup does not use github token #2874

merged 12 commits into from
Jul 21, 2025

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Jul 21, 2025

Currently integration tests are being throttled, this should not happen when github token is used.
It seems that sub-workflows it should be passed or used as github.token, see here:
https://docs.github.com/en/actions/tutorials/use-github_token-in-workflows#using-the-github_token-in-a-workflow

Signed-off-by: Attila Mészáros a_meszaros@apple.com

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@openshift-ci openshift-ci bot requested review from metacosm and xstefank July 21, 2025 11:23
csviri added 10 commits July 21, 2025 14:27
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
Copy link
Collaborator Author

csviri commented Jul 21, 2025

It seems that the issue was with minikube itself; it makes HTTP calls to the GitHub API if a newer version of Kubernetes is passed to it than is officially supported. (for example 1.33.3 is not supported but 1.33.1 is)

cc @xstefank @manusa @metacosm

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri csviri requested a review from xstefank July 21, 2025 13:29
@csviri csviri merged commit 1971fbb into main Jul 21, 2025
25 checks passed
@csviri csviri deleted the fix-github-secret branch July 21, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants