Skip to content

fix: minikube setup does not use github token #2874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 21, 2025
Merged

fix: minikube setup does not use github token #2874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
654aa14
fix: minikube setup does not use github token
csviri Jul 21, 2025
260711b
naming improvement
csviri Jul 21, 2025
ecb5999
experiment
csviri Jul 21, 2025
ee7641c
revert
csviri Jul 21, 2025
4b21a2d
test
csviri Jul 21, 2025
d27c954
test
csviri Jul 21, 2025
197d6ea
wip
csviri Jul 21, 2025
9928f63
wip
csviri Jul 21, 2025
70e2678
experiment
csviri Jul 21, 2025
051a3da
test
csviri Jul 21, 2025
0590361
fix
csviri Jul 21, 2025
e6b9601
comment
csviri Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@ jobs:
strategy:
matrix:
java: [ 17, 21, 24 ]
kubernetes: [ '1.30.12', '1.31.8', '1.32.4','1.33.0' ]
# Use the latest versions supported by minikube, otherwise GitHub it will
# end up in a throttling requests from minikube and workflow will fail.
# Minikube does such requests only if a version is not officially supported.
kubernetes: [ '1.30.12', '1.31.8', '1.32.4','1.33.1' ]
uses: ./.github/workflows/integration-tests.yml
with:
java-version: ${{ matrix.java }}
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/e2e-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Integration and end to end tests which runs locally and deploys the Operator to a Kubernetes
# (Minikube) cluster and creates custom resources to verify the operator's functionality
name: Integration & End to End tests
name: End to End tests
on:
pull_request:
paths-ignore:
Expand Down Expand Up @@ -32,8 +32,11 @@ jobs:
- name: Setup Minikube-Kubernetes
uses: manusa/actions-setup-minikube@v2.14.0
with:
minikube version: v1.34.0
kubernetes version: v1.33.0
minikube version: v1.36.0
# Use the latest versions supported by minikube, otherwise GitHub it will
# end up in a throttling requests from minikube and workflow will fail.
# Minikube does such requests only if a version is not officially supported.
kubernetes version: v1.33.1
github token: ${{ secrets.GITHUB_TOKEN }}
driver: docker

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ jobs:
- name: Set up Minikube
uses: manusa/actions-setup-minikube@v2.14.0
with:
minikube version: 'v1.34.0'
minikube version: 'v1.36.0'
kubernetes version: '${{ inputs.kube-version }}'
driver: 'docker'
github token: ${{ secrets.GITHUB_TOKEN }}
github token: ${{ github.token }}

- name: "${{inputs.it-category}} integration tests (kube: ${{ inputs.kube-version }} / java: ${{ inputs.java-version }} / client: ${{ inputs.http-client }})"
run: |
if [ -z "${{inputs.it-category}}" ]; then
Expand Down