-
Notifications
You must be signed in to change notification settings - Fork 66
🌱 In-tree test operator #2070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
🌱 In-tree test operator #2070
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2070 +/- ##
==========================================
- Coverage 74.66% 73.31% -1.36%
==========================================
Files 81 77 -4
Lines 7365 7056 -309
==========================================
- Hits 5499 5173 -326
- Misses 1528 1542 +14
- Partials 338 341 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
… pull images from it when creating pods Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Description
Adds the scaffolding for the test-operator in versions v1 and v2 using operator-sdk. The test-operator is a basic echo service.
The test-operator supports AllNamespaces, SingleNamespace, and OwnNamespace install modes.
v1 has validating and mutating webhooks
v2 has validating, mutating and conversion webhooks
TODO
test/test-operator/Makefile
: tie in the building of the controllers, bundles, and catalogtest/test-operator/test-operator-catalog.json
: test-operator package catalogThing we should feel confident in doing in the future
Risks
v1
A reconciled test-operator v1 resource would look like this:
The v1 operator also includes a validating and mutating webhook. The validating webhook validates
.spec.message
against a keyword and rejects admission if its found. The mutating webhook is used as a "defaulting" webhook that sets.spec.message
to the default message ofEcho
.v2
A reconciled test-operator v2 resource would look like this:
The same webhooks are available for v2 apis + a conversion webhook to support the CRD upgrade.
Reviewer Checklist