Add tests for latest purl-spec #202
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TG1999 I am not sure this would be the way to go. I think we should instead use a git module to get the new spec tests, but we do not want to continue to extend this JSON file. |
|
@pombredanne got it, so we need to use https://github.com/package-url/purl-spec/tree/main/tests as a git module for tests. |
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
force-pushed
the
add_tests_for_purl-spec
branch
from
5f658a8 to
4c237ce
Compare
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Aug 8, 2025
0.17.5 (2025-08-06) - Remove support for getting download URL for qpkg in ``purl2url``. package-url/packageurl-python#202 0.17.4 (2025-08-05) - Add support for getting download URL for debian, apk, qpkg in ``purl2url``. package-url/packageurl-python#201
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
keshav-space
requested changes
Aug 14, 2025
| @@ -0,0 +1,3 @@ | |||
| [submodule "spec"] | |||
| path = spec | |||
There was a problem hiding this comment.
Since we're only using purl-spec test data, we should keep it inside tests/data/.
Suggested change
| path = spec | |
| path = tests/data/purl-spec/ |
There was a problem hiding this comment.
I guess we should not keep the complete spec in tests
Comment on lines
+141
to
+153
| # MLflow purl names are case-sensitive for Azure ML, it is case sensitive and must be kept as-is in the package URL | ||
| # For Databricks, it is case insensitive and must be lowercased in the package URL | ||
| if isinstance(qualifiers, dict): | ||
| repo_url = qualifiers.get("repository_url") | ||
| if repo_url and "azureml" in repo_url.lower(): | ||
| return name_str | ||
| if repo_url and "databricks" in repo_url.lower(): | ||
| return name_str.lower() | ||
| if isinstance(qualifiers, str): | ||
| if "azureml" in qualifiers.lower(): | ||
| return name_str | ||
| if "databricks" in qualifiers.lower(): | ||
| return name_str.lower() |
There was a problem hiding this comment.
We should abstract this out into a separate function.
| @@ -464,8 +486,21 @@ def from_string(cls, purl: str) -> Self: | |||
| if not type_ or not sep: | |||
| raise ValueError(f"purl is missing the required type component: {purl!r}.") | |||
|
|
|||
| if not all(c in string.ascii_letters + string.digits + "-._" for c in type_): | |||
There was a problem hiding this comment.
Suggested change
| if not all(c in string.ascii_letters + string.digits + "-._" for c in type_): | |
| valid_chars = string.ascii_letters + string.digits + ".-_" | |
| if not all(c in valid_chars for c in type_): |
Comment on lines
+494
to
+495
| if ":" in type_: | ||
| raise ValueError(f"purl type cannot contain a colon: {type_!r}.") |
There was a problem hiding this comment.
This part is not reachable because : is not present in valid_chars
Comment on lines
+42
to
+43
| with open(valid_purl_types_file, "r", encoding="utf-8") as f: | ||
| valid_purl_types = json.load(f) |
There was a problem hiding this comment.
Are we using valid_purl_types any where in test?
| if expected_failure: | ||
| with pytest.raises(Exception): | ||
| PackageURL.from_string(input_str) | ||
| # assert None ==PackageURL.from_string(input_str) |
There was a problem hiding this comment.
Suggested change
| # assert None ==PackageURL.from_string(input_str) |
Comment on lines
+111
to
+117
| SPEC_DIR = os.path.join(os.path.dirname(__file__), "..", "spec", "tests", "types") | ||
| spec_dict = load_spec_files(SPEC_DIR) | ||
|
|
||
| flattened_cases = [] | ||
| for filename, cases in spec_dict.items(): | ||
| for case in cases: | ||
| flattened_cases.append((filename, case["description"], case)) |
There was a problem hiding this comment.
Let's move this to the top.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.