Skip to content

[#IOPID-2514] upgrade to node20 #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 8, 2025
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devops/code-review-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#

variables:
NODE_VERSION: '18.13.0'
NODE_VERSION: '20.12.2'
YARN_CACHE_FOLDER: $(Pipeline.Workspace)/.yarn
setupTemplateName: azure-templates/setup-project.yml

Expand Down
2 changes: 1 addition & 1 deletion .devops/deploy-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#

variables:
NODE_VERSION: '18.13.0'
NODE_VERSION: '20.12.2'
YARN_CACHE_FOLDER: $(Pipeline.Workspace)/.yarn
gitReference: ${{ replace(replace(variables['Build.SourceBranch'], 'refs/tags/', ''), 'refs/heads/', '') }}

Expand Down
5 changes: 4 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ module.exports = {
"@pagopa/eslint-config/strong",
],
"rules": {

"jsdoc/newline-after-description": "off",
// this rule is a replacement for the above one which got removed but it's still
// mentioned in @pagopa/eslint-config@3.0.0
"jsdoc/tag-lines": ["error", "any", {"startLines": 1}]
}
}
2 changes: 1 addition & 1 deletion .node-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.13.0
20.12.2
1 change: 0 additions & 1 deletion .nvmrc

This file was deleted.

4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:18.13.0 as builder
FROM node:20.12.2 as builder

WORKDIR /usr/src/app

Expand All @@ -11,7 +11,7 @@ RUN chmod -R 777 /usr/src/app \
&& yarn install \
&& yarn build

FROM node:18.13.0-alpine
FROM node:20.12.2-alpine
LABEL maintainer="https://pagopa.gov.it"

WORKDIR /usr/src/app
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.override.dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ version: "2.2"

services:
io-spid-commons:
image: node:18.13.0-alpine
image: node:20.12.2-alpine
working_dir: /usr/src/app
volumes:
- ".:/usr/src/app"
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ services:
- "3000"
ports:
- "3000:3000"
image: node:18.13.0-alpine
image: node:20.12.2-alpine
working_dir: /usr/src/app
volumes:
- "./certs:/usr/src/app/certs:delegated"
Expand Down
9 changes: 5 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"@pagopa/eslint-config": "^3.0.0",
"@types/express": "4.17.11",
"@types/jest": "^29.5.1",
"@types/node": "~18.13.0",
"@types/node": "~20.12.2",
"@types/node-fetch": "^2.1.2",
"@types/node-forge": "^0.9.1",
"@types/passport": "^1.0.2",
Expand All @@ -39,11 +39,11 @@
"@types/xml-crypto": "^1.4.1",
"@types/xml2js": "^0.4.5",
"@types/yargs": "^15.0.4",
"fp-ts": "^2.16.5",
"io-ts": "^2.2.21",
"auto-changelog": "^2.2.1",
"eslint-plugin-prettier": "^4.2.1",
"express": "4.17.0",
"fp-ts": "^2.16.5",
"io-ts": "^2.2.21",
"jest": "^29.5.0",
"nock": "^11.7.1",
"nodemon": "^2.0.2",
Expand Down Expand Up @@ -100,6 +100,7 @@
"access": "public"
},
"resolutions": {
"@types/express-serve-static-core": "4.17.34"
"@types/express-serve-static-core": "4.17.34",
"eslint-plugin-jsdoc": "^50"
}
}
Loading
Loading